[ 
https://issues.apache.org/jira/browse/CASSANDRA-17679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17574904#comment-17574904
 ] 

Jeremiah Jordan edited comment on CASSANDRA-17679 at 8/3/22 7:33 PM:
---------------------------------------------------------------------

Is there a reason we need a new option here?  We already have the 
"-Dcassandra.reset_bootstrap_progress" flag which disables resuming: 
[https://github.com/apache/cassandra/blob/cassandra-3.11/src/java/org/apache/cassandra/service/StorageService.java#L1608]

Do we just need to make the already existing flag more discoverable?

Also I would not mention ZCS as a reason to disable this.  ZCS applies pretty 
narrowly right now since it only works for whole files.  So for the most part 
only works if you are using LCS, which is not the default compaction strategy.


was (Author: jjordan):
Is there a reason we need a new option here?  We already have the 
"-Dcassandra.reset_bootstrap_progress" flag which disables resuming: 
[https://github.com/apache/cassandra/blob/cassandra-3.11/src/java/org/apache/cassandra/service/StorageService.java#L1608]

Do we just need to make the already existing flag more discoverable?

> Make resumable bootstrap feature optional
> -----------------------------------------
>
>                 Key: CASSANDRA-17679
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17679
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Consistency/Streaming
>            Reporter: Josh McKenzie
>            Assignee: Josh McKenzie
>            Priority: Normal
>             Fix For: 4.x
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> From the patch I'm working on:
> {code}
> # In certain environments, operators may want to disable resumable bootstrap 
> in order to avoid potential correctness
> # violations or data loss scenarios. Largely this centers around nodes going 
> down during bootstrap, tombstones being
> # written, and potential races with repair. By default we leave this on as 
> it's been enabled for quite some time,
> # however the option to disable it is more palatable now that we have zero 
> copy streaming as that greatly accelerates
> # bootstraps. This defaults to true.
> # resumable_bootstrap_enabled: true
> {code}
> Not really a great fit for guardrails as it's less a "feature to be toggled 
> on and off" and more a subset of a specific feature that in certain 
> circumstances can lead to issues.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to