[
https://issues.apache.org/jira/browse/CASSANDRA-17777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17575551#comment-17575551
]
Yifan Cai edited comment on CASSANDRA-17777 at 8/5/22 4:17 AM:
---------------------------------------------------------------
[Build
fails|https://app.circleci.com/pipelines/github/yifan-c/cassandra/370/workflows/5607061e-7f94-49a8-880b-382b7a811e73/jobs/3352]
at "checkStyle" step. Looks like recently, "Path#toFile" is disabled in
CASSANDRA-17769.
was (Author: yifanc):
Build fails at "checkStyle" step. Looks like recently, "Path#toFile" is
disabled in CASSANDRA-17769.
> Skip sstable startup checks for dropped system tables
> -----------------------------------------------------
>
> Key: CASSANDRA-17777
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17777
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Startup and Shutdown
> Reporter: Josh McKenzie
> Assignee: Josh McKenzie
> Priority: Normal
> Fix For: 4.2
>
>
> In CASSANDRA-8049 we changed our behavior to explicitly not startup while
> iterating over the whole data file directory before loading schema. In the
> case where you have (admittedly _very)_ old files left around from dropped
> system tables from old C* versions (think 1.0 era), you can end up with
> clusters that won't start due to what was, at the time, normal operations.
> We should change from hard killing nodes to instead warn operators they have
> leftovers of old system tables that need to be cleaned up. Ideally these
> files would be manually removed by operators before the upgrade to new
> versions however we can't always rely on this so killing nodes on startup for
> this specific case is suboptimal. We certainly still need to log the found
> files to give operators an indication of what needs to be cleaned up.
> While we can't load the schema to make sure all directories are safe, we
> _can_ know which tables exist in the system keyspace so we should be able to
> safely modify this startup check to log rather than kill for system tables
> only.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
