[ 
https://issues.apache.org/jira/browse/CASSANDRA-17575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17576990#comment-17576990
 ] 

Ekaterina Dimitrova commented on CASSANDRA-17575:
-------------------------------------------------

Overall LGTM.

>From what I see the patch is the same for all branches (4.0 link in the table 
>is broken but I found it from the CI run), I left just two tiny suggestions on 
>the 3.11 PR.

CI also good. All known failures, some will disappear after rebase, like the 
simulator one which was recently fixed.

 

 

> forceCompactionForTokenRange when using a wrapped range may include sstables 
> not within that range
> --------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-17575
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17575
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Local/Compaction
>            Reporter: David Capwell
>            Assignee: Andres de la Peña
>            Priority: Normal
>             Fix For: 3.11.x, 4.0.x, 4.1.x
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> This was found in CASSANDRA-17537
> When you compact the range (32, 31] this should include everything BUT 32, 
> but in the test 
> org.apache.cassandra.db.compaction.LeveledCompactionStrategyTest#testTokenRangeCompaction
>  it found that SSTables with the bounds (32, 32) were getting included in the 
> set of SSTables to compact



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to