[
https://issues.apache.org/jira/browse/CASSANDRA-17757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17578518#comment-17578518
]
Stefan Miklosovic commented on CASSANDRA-17757:
-----------------------------------------------
Hi [~paulo] , I would be delighted to have a review from you. It is rather
straightforward patch. I had to parse manifests to see if a snapshot is
ephemeral or not in order to skip it from deletion. SnapshotLoader seems to be
best suitable for the job, I just accommodated it to my use case - from now on
SnapshotLoader is able to list snapshots of some specific keyspace only. This
is quite handy as we do not need to load all the snapshots when a user wants to
clear snapshots for some keyspace only.
> A user should not be able to manually remove ephemeral snapshots
> ----------------------------------------------------------------
>
> Key: CASSANDRA-17757
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17757
> Project: Cassandra
> Issue Type: New Feature
> Components: Local/Snapshots
> Reporter: Stefan Miklosovic
> Assignee: Stefan Miklosovic
> Priority: Normal
> Fix For: 4.2
>
>
> in CASSANDRA-16911 we introduced the "-e" flag to nodetool listsnaphots which
> are returning ephemerals as well. An operator might try to remove these
> snapshots by hand. This should not be possible as these snapshots are there
> for repair to work on and manual removal breaks it. To be complete, these
> snapshots are removed as part of repair mechanism automatically, or they are
> removed on the next reboot upon node' start. They should never be removed by
> a human.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
