[ 
https://issues.apache.org/jira/browse/CASSANDRA-17753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17579250#comment-17579250
 ] 

Michael Semb Wever edited comment on CASSANDRA-17753 at 8/20/22 7:49 AM:
-------------------------------------------------------------------------

{quote}In -src, this file is excluded: 
[https://github.com/apache/cassandra/blob/a45e70a860e9d68745f463f5a06aa7b870ff69df/build.xml#L1321]
{quote}
That is correct. And you cannot (are not allowed to) put the version.properties 
into the -src tarball.

The -src tarball is a snapshot of our source, from version control from a 
stated SHA, nothing generated or custom added.

It needs to be possible to do {{`tar xvf \*-src.tar.gz ; cd apache-cassandra\* 
; ant artifacts`}} without git or the generated version.properties being 
present.


was (Author: michaelsembwever):
{quote}In -src, this file is excluded: 
[https://github.com/apache/cassandra/blob/a45e70a860e9d68745f463f5a06aa7b870ff69df/build.xml#L1321]
{quote}
That is correct. And you cannot (are not allowed to) put the version.properties 
into the -src tarball.

The -src tarball is a snapshot of our source, from version control from a 
stated SHA, nothing generated or custom added.

It needs to be possible to do {{`tar xvf *-src.tar.gz ; cd apache-cassandra* ; 
ant artifacts`}} without git or the generated version.properties being present.

> Include GitSHA in nodetool version output
> -----------------------------------------
>
>                 Key: CASSANDRA-17753
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17753
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Tool/nodetool
>            Reporter: Abe Ratnofsky
>            Assignee: Abe Ratnofsky
>            Priority: Normal
>             Fix For: 4.x
>
>          Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> It can be useful to see specifically which Git SHA a running instance of 
> Cassandra was built with, especially when running clusters in development for 
> soak testing.
>  
> I have a patch ready for this, and am preparing it now.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to