[
https://issues.apache.org/jira/browse/CASSANDRA-17618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17585587#comment-17585587
]
Brandon Williams commented on CASSANDRA-17618:
----------------------------------------------
Though this bisected to CASSANDRA-17044, I think it just changed the timing
enough to expose other problems. The first is a race that is mostly noise and
is just like [this
one|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/net/InboundConnectionInitiator.java#L464],
but instead
[here|https://github.com/driftx/cassandra/commit/568f2166f84908f1c7f240d6f2f7de0591d46a59].
The second issue is that when a connection is attempted unencrypted we call
[failHandshake|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/net/InboundConnectionInitiator.java#L320]
but don't return afterward, which then relies on a later write to call
[uncaughtException|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/net/InboundConnectionInitiator.java#L339]
which it seems in some instances is too late and allows
[setupMessagingPipeline|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/net/InboundConnectionInitiator.java#L357]
to run, causing the messageHandler to be present when the test checks them. I
don't see any reason to not return after failing, but there are other instances
where we don't and this isn't in my area expertise. [~aleksey] this is your
test, can you advise?
> Fix flaky
> org.apache.cassandra.distributed.test.InternodeEncryptionEnforcementTest
> ----------------------------------------------------------------------------------
>
> Key: CASSANDRA-17618
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17618
> Project: Cassandra
> Issue Type: Bug
> Components: CI
> Reporter: Ekaterina Dimitrova
> Assignee: Brandon Williams
> Priority: Normal
> Fix For: 4.1-beta
>
>
> The test is flaky on 4.1:
> https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1604/workflows/243a20a5-eda2-4c28-95e8-ab6c4f85a891/jobs/10911
> {code:java}
> junit.framework.AssertionFailedError: expected:<0> but was:<1>
> at
> org.apache.cassandra.distributed.test.InternodeEncryptionEnforcementTest.lambda$testConnectionsAreRejectedWithInvalidConfig$81c80a4a$1(InternodeEncryptionEnforcementTest.java:91)
> at org.apache.cassandra.concurrent.FutureTask$1.call(FutureTask.java:81)
> at org.apache.cassandra.concurrent.FutureTask.call(FutureTask.java:47)
> at org.apache.cassandra.concurrent.FutureTask.run(FutureTask.java:57)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at
> io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
> at java.lang.Thread.run(Thread.java:748)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
