[ 
https://issues.apache.org/jira/browse/CASSANDRA-17889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17604022#comment-17604022
 ] 

Andres de la Peña commented on CASSANDRA-17889:
-----------------------------------------------

It sounds very reasonable to me.

By the way, it seems there's a mistake in [the way the error message is 
formatted|https://github.com/apache/cassandra-dtest/blob/trunk/tools/hacks.py#L60]:
{noformat}
AssertionError: It's been over a {s}s and we haven't written a new commitlog 
segment. Something is wrong.
{noformat}
I think we should use:
{code:python}
time.time() <= stop_time), "It's been over {%s}s and we haven't written a new " 
+ \
"commitlog segment. Something is wrong.".format(s=timeout)
{code}

> Fix flaky test_archive_commitlog_point_in_time
> ----------------------------------------------
>
>                 Key: CASSANDRA-17889
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17889
>             Project: Cassandra
>          Issue Type: Bug
>          Components: CI
>            Reporter: Ekaterina Dimitrova
>            Assignee: Ekaterina Dimitrova
>            Priority: Normal
>             Fix For: 4.0.x, 4.1.x, 4.x
>
>
> Spotted in butler to fail for 4.0, 4.1 and trunk:
> h3.  
> {code:java}
> Error Message
> AssertionError: It's been over a {s}s and we haven't written a new commitlog 
> segment. Something is wrong.
> Stacktrace
> self = <snapshot_test.TestArchiveCommitlog object at 0x7efe72087d00> def 
> test_archive_commitlog_point_in_time(self): """ Test archive commit log with 
> restore_point_in_time setting """ > 
> self.run_archive_commitlog(restore_point_in_time=True) snapshot_test.py:259: 
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
> _ snapshot_test.py:301: in run_archive_commitlog advance_to_next_cl_segment( 
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> {code}
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to