[
https://issues.apache.org/jira/browse/CASSANDRA-17240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17611278#comment-17611278
]
Caleb Rackliffe commented on CASSANDRA-17240:
---------------------------------------------
Apologies for the delay. I've just finished my review. My main concerns were,
as you would expect, looking at test coverage, making sure the functionality
we've added is disabled by default, and making sure there isn't too much risk
to the existing Memtable infrastructure. I've left a raft of comments inline in
the PR, none of which are particularly alarming.
I've had a brief conversation w/ [~ifesdjeen] about this, and I anticipate he
might be able to sync up w/ [~blambov] at ApacheCon net week, but the only
larger question I have is whether we want to leverage the existing capabilities
of Harry to fuzz test this at a high level w/ {{TieMemtable}}. (I imagine that
might be a better tool to de-risk things like merging Memtable and SSTable
contents for client queries, RR, etc.)
+1 Otherwise
> CEP-19: Trie memtable implementation
> ------------------------------------
>
> Key: CASSANDRA-17240
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17240
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Memtable
> Reporter: Branimir Lambov
> Assignee: Branimir Lambov
> Priority: Normal
> Attachments: SkipListMemtable-OSS.png, TrieMemtable-OSS.png,
> density_SG.html.gz, density_test_with_sharding.html.gz, latency-1_1-95.png,
> latency-9_1-95.png, throughput_SG.png, throughput_apache.png
>
> Time Spent: 10h 50m
> Remaining Estimate: 0h
>
> Trie-based memtable implementation as described in CEP-19, built on top of
> CASSANDRA-17034 and CASSANDRA-6936.
> The implementation is available in this
> [branch|https://github.com/blambov/cassandra/tree/CASSANDRA-17240].
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
