[
https://issues.apache.org/jira/browse/CASSANDRA-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17611795#comment-17611795
]
Ekaterina Dimitrova edited comment on CASSANDRA-17912 at 10/1/22 12:32 AM:
---------------------------------------------------------------------------
We provide non-default
[test_filter_pattern|https://github.com/apache/cassandra/blob/cassandra-3.0/.circleci/config-2_1.yml#L456]
in 3.0 and 3.11 which identifies only the tests under upgrade_tests dir.
Without applying it, the way we do in 4.0+, we get additionally below tests in
the list of tests to run:
{code:java}
+upgrade_crc_check_chance_test.py::TestCrcCheckChanceUpgrade::test_crc_check_chance_upgrade
+upgrade_internal_auth_test.py::TestAuthUpgrade::test_upgrade_to_22
+upgrade_internal_auth_test.py::TestAuthUpgrade::test_upgrade_to_30
+upgrade_internal_auth_test.py::TestAuthUpgrade::test_upgrade_legacy_table
{code}
Jenkins 3252 vs 3299 Circle
Still the calculation difference is more than only 4 tests... if I look at the
right numbers in Jenkins
I don't see us doing [that
filtering|https://github.com/apache/cassandra-builds/blob/trunk/build-scripts/cassandra-dtest-pytest.sh#L99]
in Jenkins and it seems to me that we shouldn't do it, the way it is in 4.0+
I will continue on Monday
was (Author: e.dimitrova):
We provide non-default
[test_filter_pattern|https://github.com/apache/cassandra/blob/cassandra-3.0/.circleci/config-2_1.yml#L456]
in 3.0 and 3.11 which identifies only the tests under upgrade_tests dir.
Without applying it, the way we do in 4.0+, we get additionally below tests in
the list of tests to run:
{code:java}
+upgrade_crc_check_chance_test.py::TestCrcCheckChanceUpgrade::test_crc_check_chance_upgrade
+upgrade_internal_auth_test.py::TestAuthUpgrade::test_upgrade_to_22
+upgrade_internal_auth_test.py::TestAuthUpgrade::test_upgrade_to_30
+upgrade_internal_auth_test.py::TestAuthUpgrade::test_upgrade_legacy_table
{code}
Jenkins 3252 vs 3299 Circle
Still the calculation difference is more than only 4 tests... if I count
correctly.
I don't see us doing [that
filtering|https://github.com/apache/cassandra-builds/blob/trunk/build-scripts/cassandra-dtest-pytest.sh#L99]
in Jenkins and it seems to me that we shouldn't do it, the way it is in 4.0+
I will continue on Monday
> Fix CircleCI config for running Python upgrade tests on 3.0 and 3.11
> --------------------------------------------------------------------
>
> Key: CASSANDRA-17912
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17912
> Project: Cassandra
> Issue Type: Bug
> Components: CI
> Reporter: Ekaterina Dimitrova
> Assignee: Ekaterina Dimitrova
> Priority: Normal
> Fix For: 3.0.x, 3.11.x
>
>
> It was noticed that Circle CI pushes to run irrelevant for 3.0 and 3.11
> Python upgrade tests. Those are properly skipped in Jenkins.
> Example runs:
> [CircleCI|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1931/workflows/39ef5261-a6bf-4e77-a412-e750e322a231/jobs/15293]
> - 3.0 run
> [Jenkins|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/1944/]
> - while typing this I actually noticed [one
> test|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/1944/testReport/junit/dtest-upgrade.upgrade_tests.upgrade_through_versions_test/TestProtoV3Upgrade_AllVersions_RandomPartitioner_EndsAt_3_11_X_HEAD/test_parallel_upgrade_with_internode_ssl/]
> only looking suspicious in Jenkins as it ends the upgrade in 3.11 when we
> test 3.0...
> This is good to be fixed for two reasons - reduce the noise so we do not miss
> legit failures and we should not spend resources to try to run those tests.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
