[
https://issues.apache.org/jira/browse/CASSANDRA-17939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17615729#comment-17615729
]
Andres de la Peña edited comment on CASSANDRA-17939 at 10/11/22 12:10 PM:
--------------------------------------------------------------------------
As for running the actual diff on CircleCI instead of running it locally:
* It allows the detection of new and modified tests even if the user doesn't
use the {{generate.sh}} script when pushing.
* It prevents us from doing shallow clones ({{git clone --depth 1}}). This
means a slightly longer build and a bigger working directory to be copied to
every runner. Running the diff locally would require less resources.
* It ensures that we use the right remote and base branch when running the
diff, whereas a local diff would require the right config on the user's machine.
* The results of a local call to {{generate.sh -d}} could be different to what
is actually run on CircleCI. However that seems unlikely given that we use
three-dot diffs. Having more commits on top of the base branch when the tests
are run shouldn't make a difference.
was (Author: adelapena):
As for running the actual diff on CircleCI instead of running it locally:
* It allows the detection of new and modified tests even if the user doesn't
use the {{generate.sh}} script when pushing.
* It prevents us from doing shallow clones ({{git clone --depth 1}}). This
means slightly a slightly longer build and a bigger working directory to be
copied to every runner. Running the diff locally would require less resources.
* It ensures that we use the right remote and base branch when running the
diff, whereas a local diff would require the right config on the user's machine.
* The results of {{generate.sh -d}} could be different to what is actually run
on server. However that seems unlikely given that we use three-dot diffs, so
having more commits on top of the base branch when the tests are run shouldn't
make a difference.
> CircleCI: Automatically detect and repeat new or modified JUnit tests
> ---------------------------------------------------------------------
>
> Key: CASSANDRA-17939
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17939
> Project: Cassandra
> Issue Type: Task
> Components: CI
> Reporter: Andres de la Peña
> Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.x
>
>
> The purpose of this ticket is adding a new CircleCI job that automatically
> detects new or modified test classes and runs them repeatedly. That way we
> wouldn't need to manually specify those tests with {{.circleci/generate.sh}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
