[
https://issues.apache.org/jira/browse/CASSANDRA-17939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616565#comment-17616565
]
Josh McKenzie commented on CASSANDRA-17939:
-------------------------------------------
Functionality tests out fine. Will be reviewing the actual code soon(tm).
nit: wdyt about renaming the j8_build approval step on j8_pre-commit to
something like "all_jdk_build"? Also, could serve to rename j8_pre-commit to
"all_jdk_precommit".
[https://app.circleci.com/pipelines/github/adelapena/cassandra/2218/workflows/1cc5669f-e894-488d-a47c-99e2c4d32acd]
That way we could document it as the "one-stop-shop" to hit the button and get
all your test results.
Also, while we're here (famous last words...) - could we also deprecate the -l,
-m, and -h flags, fail out on -l (since I believe it doesn't work at all?) and
have -m and -h just route to a default that hits up -m as per the discussion
above w/a debug print out letting the user know we re-routed? i.e. get us to a
place where we have a very straightforward flow like:
1. Run .circleci/generate.sh
2. Visually confirm the tests you expect to see changed show up in the repeated
run output in console
3. {{git commit -a -m "[DO NOT MERGE] circleci config" (could even add a
convenience wrapper to .circleci that'd generate + commit...)
4. After push, go to circleci pipeline and click the {{all_jdk_precommit}}
{{all_jdk_build}} job to approve it. Wait, review.
> CircleCI: Automatically detect and repeat new or modified JUnit tests
> ---------------------------------------------------------------------
>
> Key: CASSANDRA-17939
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17939
> Project: Cassandra
> Issue Type: Task
> Components: CI
> Reporter: Andres de la Peña
> Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.x
>
>
> The purpose of this ticket is adding a new CircleCI job that automatically
> detects new or modified test classes and runs them repeatedly. That way we
> wouldn't need to manually specify those tests with {{.circleci/generate.sh}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
