[
https://issues.apache.org/jira/browse/CASSANDRA-17964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17618783#comment-17618783
]
Stefan Miklosovic edited comment on CASSANDRA-17964 at 10/17/22 9:22 AM:
-------------------------------------------------------------------------
Hi [~k-rus]
do you want to be involved in this patch so you provide fixes for all branches
or are you ok with us doing that?
We should probably rename all these tests as well:
{code}
cassandra-3.11$ find . -type f -name '*Tests\.java'
./test/unit/org/apache/cassandra/utils/UUIDTests.java
./test/unit/org/apache/cassandra/cql3/BatchTests.java
cassandra-4.0$ find . -type f -name '*Tests\.java'
./test/unit/org/apache/cassandra/utils/UUIDTests.java
./test/unit/org/apache/cassandra/cql3/BatchTests.java
cassandra-4.1$ find . -type f -name '*Tests\.java'
./test/unit/org/apache/cassandra/utils/UUIDTests.java
./test/unit/org/apache/cassandra/auth/CassandraAuthorizerTruncatingTests.java
./test/unit/org/apache/cassandra/service/paxos/uncommitted/PaxosUncommittedTests.java
./test/unit/org/apache/cassandra/cql3/BatchTests.java
cassandra$ find . -type f -name '*Tests\.java'
./test/unit/org/apache/cassandra/utils/UUIDTests.java
./test/unit/org/apache/cassandra/auth/CassandraAuthorizerTruncatingTests.java
./test/unit/org/apache/cassandra/service/paxos/uncommitted/PaxosUncommittedTests.java
./test/unit/org/apache/cassandra/cql3/BatchTests.java
{code}
was (Author: smiklosovic):
Hi [~k-rus]
do you want to be involved in this patch so you provide fixes for all branches
or are you ok with us doing that?
We should probably rename all these tests as well:
{code}
cassandra-3.11$ find . -type f -name '*Tests\.java'
./test/unit/org/apache/cassandra/utils/UUIDTests.java
./test/unit/org/apache/cassandra/utils/KillerForTests.java
./test/unit/org/apache/cassandra/cql3/BatchTests.java
cassandra-4.0$ find . -type f -name '*Tests\.java'
./test/unit/org/apache/cassandra/utils/UUIDTests.java
./test/unit/org/apache/cassandra/utils/KillerForTests.java
./test/unit/org/apache/cassandra/cql3/BatchTests.java
cassandra-4.1$ find . -type f -name '*Tests\.java'
./test/unit/org/apache/cassandra/utils/UUIDTests.java
./test/unit/org/apache/cassandra/utils/KillerForTests.java
./test/unit/org/apache/cassandra/auth/CassandraAuthorizerTruncatingTests.java
./test/unit/org/apache/cassandra/service/paxos/uncommitted/PaxosUncommittedTests.java
./test/unit/org/apache/cassandra/cql3/BatchTests.java
cassandra$ find . -type f -name '*Tests\.java'
./test/unit/org/apache/cassandra/utils/UUIDTests.java
./test/unit/org/apache/cassandra/utils/KillerForTests.java
./test/unit/org/apache/cassandra/auth/CassandraAuthorizerTruncatingTests.java
./test/unit/org/apache/cassandra/service/paxos/uncommitted/PaxosUncommittedTests.java
./test/unit/org/apache/cassandra/cql3/BatchTests.java
{code}
> BatchTests are never executed due to naming violation
> -----------------------------------------------------
>
> Key: CASSANDRA-17964
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17964
> Project: Cassandra
> Issue Type: Task
> Reporter: Ruslan Fomkin
> Priority: Normal
>
> [BatchTests|https://github.com/apache/cassandra/blob/trunk/test/unit/org/apache/cassandra/cql3/BatchTests.java]
> doesn't follow naming convention to be run as unit tests and, thus, is never
> run.
> The rule in build expects names as `*Test`.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
