[
https://issues.apache.org/jira/browse/CASSANDRA-17964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17618803#comment-17618803
]
Stefan Miklosovic commented on CASSANDRA-17964:
-----------------------------------------------
I would fix it for 3.0 as well.
So, you should rename all files I mentioned in my first comment PLUS we need to
add checkstyle check for cassandra-4.1 and trunk branches.
If you apply that checkstyle for tests, we should rename KilllerForTests class
to "TestKiller", "ParametrizedTests" to "ParametrizedTest" and
"NonParametrizedTests" to "NonParametrizedTest" as these classes would be false
positives.
For reference, 4.1 branch with all these changes is here:
https://github.com/apache/cassandra/pull/1915/files
I do not expect that it would differ from trunk. So the remaining task is to
prepare 3.0, 3.11 and 4.0 and I do the 4.1 and trunk.
> BatchTests are never executed due to naming violation
> -----------------------------------------------------
>
> Key: CASSANDRA-17964
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17964
> Project: Cassandra
> Issue Type: Task
> Components: Test/unit
> Reporter: Ruslan Fomkin
> Assignee: Ruslan Fomkin
> Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> [BatchTests|https://github.com/apache/cassandra/blob/trunk/test/unit/org/apache/cassandra/cql3/BatchTests.java]
> doesn't follow naming convention to be run as unit tests and, thus, is never
> run.
> The rule in build expects names as `*Test`.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
