[ 
https://issues.apache.org/jira/browse/CASSANDRA-17992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17625579#comment-17625579
 ] 

Benedict Elliott Smith edited comment on CASSANDRA-17992 at 10/28/22 10:33 AM:
-------------------------------------------------------------------------------

Yes, the {{GaloisCounterMode}} appears to make about {{DirectBuffer}} and their 
attachments 
[here|https://github.com/openjdk/jdk/blob/jdk-17%2B35/src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java#L866].

Looking again at the rest of the JDK, I'm not actually sure attachments can be 
accessed publicly, so this is probably our problem rather than the JDK's. 
However, we might be able to fix it by simply having {{Chunk}} implement 
{{DirectBuffer}}, and having it return its address.


was (Author: benedict):
Yes, the {{GaloisCounterMode}} appears to make about {{DirectBuffer}} and their 
attachments 
[here|https://github.com/openjdk/jdk/blob/jdk-17%2B35/src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java#L866].

Looking again at the rest of the JDK, I'm not actually sure attachments can be 
accessed publicly, so this is probably our problem rather than the JDK's.

> Upgrade Netty on 4.x(current trunk)
> -----------------------------------
>
>                 Key: CASSANDRA-17992
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17992
>             Project: Cassandra
>          Issue Type: Task
>          Components: Dependencies
>            Reporter: Ekaterina Dimitrova
>            Priority: Low
>             Fix For: 4.x
>
>
> I haven't been able to identify from the Netty docs which was the lowest 
> version where JDK17 was added but we are about 40 versions behind in netty 4 
> so I suspect we better update. 
> We need to consider there was an issue with class cast exceptions when 
> building with JDK17 with newer versions of netty (the newest available in 
> March 2022). For the record, we didn't see those when running CI on JDK8 and 
> JDK11. We also need to carefully revise the changes between the netty 
> versions.
> Upgrading will cover also a fix in netty that was discussed in 
> [this|https://the-asf.slack.com/archives/CK23JSY2K/p1665567660202989] ASF 
> Slack thread. 
> CC [~benedict] , [~aleksey] 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to