[
https://issues.apache.org/jira/browse/CASSANDRA-18000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17628158#comment-17628158
]
Berenguer Blasi edited comment on CASSANDRA-18000 at 11/3/22 7:56 AM:
----------------------------------------------------------------------
Hi [~adelapena],
some comments:
- I left a comment for the patch
- I started a jenkins run
[here|https://ci-cassandra.apache.org/view/all/job/Cassandra-devbranch/2056/]
to make sure we are ok on jenkins as well
- I can confirm the runs look good and all 'noisy' ant targets are no longer ran
- Will this only go to trunk?
- In the spirit of removing unnecessary steps we should also remove the
'Downloading previous tests results' for multiplexed circle jobs as these can
hide massive downloads, consume time and are unnecessary. Wdyt?
was (Author: bereng):
Hi [~adelapena],
some comments:
- I left a comment for the patch
- I started a jenkins run
[here|https://ci-cassandra.apache.org/view/all/job/Cassandra-devbranch/2056/]
to make sure we are ok on jenkins as well
- I can confirm the runs look good and all 'noisy' targets are no longer ran
- Will this only go to trunk?
> CircleCI: Skip checkstyle in the Ant-based repeated tests
> ---------------------------------------------------------
>
> Key: CASSANDRA-18000
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18000
> Project: Cassandra
> Issue Type: Task
> Components: CI
> Reporter: Andres de la Peña
> Assignee: Andres de la Peña
> Priority: Normal
>
> The CircleCI jobs for repeating Ant-based tests include the {{checkstyle}}
> and {{checkstyle-test}} targets. Those targets are skipped for Java 11 but
> not for Java 8.
> Including those targets on every test iteration produces a significant
> difference in the run times of repeated test jobs for j8 and j11:
> *
> [https://app.circleci.com/pipelines/github/adelapena/cassandra/2328/workflows/122d58b9-b454-4a99-8c46-f7777b7ef225/jobs/23225]
> *
> [https://app.circleci.com/pipelines/github/adelapena/cassandra/2328/workflows/50f33d9b-c7c6-4aa9-bac9-22ac78ad6b8c/jobs/23224]
> We should use the {{no-checkstyle}} flag in the iterations done by those
> jobs. That should significantly speed up the jobs and save resources.
>
> Thanks to [~bereng] , who detected the difference in the running times
> between j8 and j11.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
