[
https://issues.apache.org/jira/browse/CASSANDRA-17964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17628986#comment-17628986
]
Stefan Miklosovic commented on CASSANDRA-17964:
-----------------------------------------------
This is what I have (1) [~dcapwell]
I reshuffled things little but. In order to be able to use that annotation in
IDE, IDE has to know about that (it has to be a proper (test) source).
Another consequence is that our ant task has to have compiled classes to do
reflection on which means I depend on build-test.
I did just 4.1 but since this is not a checkstyle module anymore, we can
introduce this to all branches from 3.0 included and fix stuff there as well.
Nothing prevents us from doing this for trunk only.
Please take a look and I will start to incorporate this into 3.0 and up.
BTW I do not think that making that check "granuluar" per test type is
necessary. Can we just make things simple for now?
(1) https://github.com/apache/cassandra/pull/1971
> Some tests are never executed due to naming violation - fix it and add
> checkstyle where applicable
> --------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-17964
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17964
> Project: Cassandra
> Issue Type: Task
> Components: Test/unit
> Reporter: Ruslan Fomkin
> Assignee: Stefan Miklosovic
> Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 4.x
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> [BatchTests|https://github.com/apache/cassandra/blob/trunk/test/unit/org/apache/cassandra/cql3/BatchTests.java]
> doesn't follow naming convention to be run as unit tests and, thus, is never
> run.
> The rule in build expects names as `*Test`.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]