[
https://issues.apache.org/jira/browse/CASSANDRA-17950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17630160#comment-17630160
]
Ekaterina Dimitrova edited comment on CASSANDRA-17950 at 11/8/22 3:56 AM:
--------------------------------------------------------------------------
Thank you both!
{quote}The patch for 3.11 looks good to me, I have left a couple of minor
suggestions on the PR.
{quote}
Feedback incorporated
[4.0|https://github.com/ekaterinadimitrova2/cassandra/commit/4e240587be247fb21808de890270e89b8848d27a],
[CI
#2042|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=17950-4.0]-
I will rework the patches which do not apply clean now when we agree on the
rest. I saw some inconsistencies in the names having both "{-}" and "{-}" in
the names and I decided to fix this In a different commit or even maybe in a
follow up ticket as otherwise things become extra noisy and super hard for
review.
Seems like in Jenkins we run CQLSH tests only Python3? But as we still do have
best effort Python2 not removed in 4.0, I kept the trend to have the Python2
jobs too.
[4.1|https://github.com/ekaterinadimitrova2/cassandra/commit/5e3b045f2afba3424efd4c86c28664b24905c06c],
[CI
#2045|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=17950-4.1]
- we removed python 2 in 4.1. Otherwise it is the same as 4.0
Trunk will be the same as 4.1.
If those look ok I can work on midres and highres patches tomorrow.
was (Author: e.dimitrova):
Thank you both!
{quote}The patch for 3.11 looks good to me, I have left a couple of minor
suggestions on the PR.
{quote}
Feedback incorporated
[4.0|https://github.com/ekaterinadimitrova2/cassandra/commit/4e240587be247fb21808de890270e89b8848d27a],
[CI
#2042|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=17950-4.0]-
I will rework the patches which do not apply clean now when we agree on the
rest. I saw some inconsistencies in the names having both "{-}" and "{-}" in
the names and I decided to fix this In a different commit or even maybe in a
follow up ticket as otherwise things become extra noisy and super hard for
review.
Seems like in Jenkins we run CQLSH tests only Python3? But as we still do have
best effort Python2 not removed in 4.0, I kept the trend to have the Python2
jobs too.
[4.1|https://github.com/ekaterinadimitrova2/cassandra/commit/5e3b045f2afba3424efd4c86c28664b24905c06c],
[CI
#2044|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=17950-4.1]
- we removed python 2 in 4.1. Otherwise it is the same as 4.0
Trunk will be the same as 4.1.
If those look ok I can work on midres and highres patches tomorrow.
> Enable dtest-offheap in CircleCI
> --------------------------------
>
> Key: CASSANDRA-17950
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17950
> Project: Cassandra
> Issue Type: Sub-task
> Components: Test/dtest/python
> Reporter: Derek Chen-Becker
> Assignee: Derek Chen-Becker
> Priority: Normal
> Fix For: 3.11.x, 4.0.x, 4.1.x, 4.x
>
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
