[
https://issues.apache.org/jira/browse/CASSANDRA-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13083077#comment-13083077
]
Pavel Yaskevich commented on CASSANDRA-2975:
--------------------------------------------
First of all - can you please rebase both with latest trunk and attach them to
JIRA?
What I see from first look (about patch for backward compatibility):
- I think we should extract interface from BloomFilter class and make BF a
factory as now we have Murmur{2,3}BloomFilter classes
- Needs a test for compatibility with old SSTables (which are using Murmur2BF)
- minor note: comment about new SSTable version is missing at the top of the
Descriptor class
As soon as you attach files in here I will apply and play with them and maybe
find other problems.
> Upgrade MurmurHash to version 3
> -------------------------------
>
> Key: CASSANDRA-2975
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2975
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Brian Lindauer
> Assignee: Brian Lindauer
> Priority: Trivial
> Labels: lhf
> Fix For: 1.0
>
>
> MurmurHash version 3 was finalized on June 3. It provides an enormous speedup
> and increased robustness over version 2, which is implemented in Cassandra.
> Information here:
> http://code.google.com/p/smhasher/
> The reference implementation is here:
> http://code.google.com/p/smhasher/source/browse/trunk/MurmurHash3.cpp?spec=svn136&r=136
> I have already done the work to port the (public domain) reference
> implementation to Java in the MurmurHash class and updated the BloomFilter
> class to use the new implementation:
> https://github.com/lindauer/cassandra/commit/cea6068a4a3e5d7d9509335394f9ef3350d37e93
> Apart from the faster hash time, the new version only requires one call to
> hash() rather than 2, since it returns 128 bits of hash instead of 64.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
