[
https://issues.apache.org/jira/browse/CASSANDRA-17928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631176#comment-17631176
]
Andres de la Peña commented on CASSANDRA-17928:
-----------------------------------------------
Yes, I think we can go ahead with the 2min timeout.
I've also run j11 and trunk with the increased timeout and all of them pass:
||Branch||CI||
|[4.1
|https://github.com/adelapena/cassandra/tree/17928-4.1-review]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/2484/workflows/7db9a37e-9866-4d6b-9445-3c5e1e751047]
[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/2484/workflows/4cc51390-8680-4638-a27c-81feb36b73e7]|
|[trunk|https://github.com/adelapena/cassandra/tree/17928-trunk-review]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/2486/workflows/3796fc67-ecfd-4e06-90cc-0751768cec25]
[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/2486/workflows/77e044a2-dde3-47ef-ac69-a36c4aca2153]|
30K iterations per config and branch is a lot of iterations. That increases our
chances of hitting both timeouts and races. I guess that seeing that the test
doesn't fail anymore when we increase the max wait time discards the
possibility of an unknown race. I suspect that most tests using
{{spinAssertEquals}} with a shorter timeout would also fail if we run them with
such a high number of iterations.
> Test Failure:
> org.apache.cassandra.db.commitlog.CommitLogInitWithExceptionTest.testCommitLogInitWithException-compression
> -------------------------------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-17928
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17928
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
> Reporter: Josh McKenzie
> Assignee: Brandon Williams
> Priority: Normal
> Fix For: 4.1-rc
>
>
> [Link|https://ci-cassandra.apache.org/job/Cassandra-4.1/169/testReport/org.apache.cassandra.db.commitlog/CommitLogInitWithExceptionTest/testCommitLogInitWithException_compression/]
> Failed 1 times in the last 14 runs. Flakiness: 7%, Stability: 92%
> Stacktrace
> {code:java}
> java.lang.NullPointerException
> at
> org.apache.cassandra.db.commitlog.CommitLogInitWithExceptionTest.testCommitLogInitWithException(CommitLogInitWithExceptionTest.java:93)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
> at java.base/java.lang.Thread.run(Thread.java:829)
> {code}
> {code:java}
> Standard Output
> INFO [main] 2022-09-25 11:43:16,512 Reflections.java:219 - Reflections took
> 1221 ms to scan 8 urls, producing 1756 keys and 6922 values
> INFO [main] 2022-09-25 11:43:17,480 Reflections.java:219 - Reflections took
> 907 ms to scan 8 urls, producing 1756 keys and 6922 values
> INFO [main] 2022-09-25 11:43:17,573 YamlConfigurationLoader.java:104 -
> Configuration location:
> file:////home/cassandra/cassandra/build/test/cassandra.compressed.yaml
> DEBUG [main] 2022-09-25 11:43:17,574 YamlConfigurationLoader
> ...[truncated 35568 chars]...
> .apache.cassandra.db.commitlog.CommitLogInitWithExceptionTest$MockCommitLogSegmentMgr.createSegment(CommitLogInitWithExceptionTest.java:106)
> at
> org.apache.cassandra.db.commitlog.AbstractCommitLogSegmentManager$AllocatorRunnable.run(AbstractCommitLogSegmentManager.java:155)
> at
> org.apache.cassandra.concurrent.InfiniteLoopExecutor.loop(InfiniteLoopExecutor.java:121)
> at
> io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
> at java.lang.Thread.run(Thread.java:748)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]