[
https://issues.apache.org/jira/browse/CASSANDRA-17997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17634332#comment-17634332
]
Derek Chen-Becker commented on CASSANDRA-17997:
-----------------------------------------------
PR for 3.11 is updated with a fix for the nit :)
PR for 3.0: [https://github.com/apache/cassandra/pull/2016]
PR for 4.0: [https://github.com/apache/cassandra/pull/2017]
PR for 4.1: [https://github.com/apache/cassandra/pull/2018]
PR for trunk is pending because it looks like your change was not applied to
trunk. I can try to make a PR that includes both changes, if that would help,
but your change looks a little complex and I might need some assistance
> Improve git branch handling for CircleCI generate.sh
> ----------------------------------------------------
>
> Key: CASSANDRA-17997
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17997
> Project: Cassandra
> Issue Type: Improvement
> Components: CI
> Reporter: Derek Chen-Becker
> Assignee: Derek Chen-Becker
> Priority: Normal
> Fix For: 3.0.x, 4.0.x, 4.1.x, 4.x
>
>
> The generate.sh script assumes a base git branch that is local and named
> after the official repo branch (e.g. `cassandra-3.11`). This may not be a
> local branch if the developer has recently cloned the repo and is creating a
> work branch, and will lead to the git commands in generate.sh failing:
>
> ```
> fatal: ambiguous argument 'cassandra-3.11...HEAD': unknown revision or path
> not in the working tree.
> Use '--' to separate paths from revisions, like this:
> 'git <command> [<revision>...] -- [<file>...]'
> ```
> We should be able to make some sanity checks to better guide or warn the
> developer if things aren't set up properly to check against git.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
