[
https://issues.apache.org/jira/browse/CASSANDRA-2849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13083480#comment-13083480
]
Hudson commented on CASSANDRA-2849:
-----------------------------------
Integrated in Cassandra-0.8 #272 (See
[https://builds.apache.org/job/Cassandra-0.8/272/])
include column name in validation failure exceptions
patch by jbellis; reviewed by David Allsopp for CASSANDRA-2849
jbellis :
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1156753
Files :
* /cassandra/branches/cassandra-0.8/CHANGES.txt
*
/cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/thrift/ThriftValidation.java
*
/cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/thrift/CassandraServer.java
> InvalidRequestException when validating column data includes entire column
> value
> --------------------------------------------------------------------------------
>
> Key: CASSANDRA-2849
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2849
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.8.1
> Reporter: David Allsopp
> Assignee: David Allsopp
> Priority: Minor
> Fix For: 0.8.5
>
> Attachments: 2849-v2.txt, cassandra-2849.diff
>
>
> If the column value fails to validate, then
> ThriftValidation.validateColumnData() calls bytesToHex() on the entire column
> value and puts this string in the Exception. Since the value may be up to
> 2GB, this is potentially a lot of extra memory. The value is likely to be
> logged (and presumably returned to the thrift client over the network?). This
> could cause a lot of slowdown or an unnecessary OOM crash, and is unlikely to
> be useful (the client has access to the full value anyway if required for
> debugging).
> Also, the reason for the exception (extracted from the MarshalException) is
> printed _after_ the data, so if there's any truncation in the logging system
> at any point, the reason will be lost.
> The reason should be displayed before the column value, and the column value
> should be truncated in the Exception message.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
