[ 
https://issues.apache.org/jira/browse/CASSANDRASC-47?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17635981#comment-17635981
 ] 

ASF subversion and git services commented on CASSANDRASC-47:
------------------------------------------------------------

Commit 02cc6548f291528e9749a51d103463f9552f4b4e in cassandra-sidecar's branch 
refs/heads/trunk from Francisco Guerrero
[ https://gitbox.apache.org/repos/asf?p=cassandra-sidecar.git;h=02cc654 ]

CASSANDRASC-47: Introduce JMX foundation in Sidecar

In this commit, we introduce the JMX foundation in Sidecar to enable the 
ability to communicate
with the Cassandra process. This commit adds new configuration parameters to 
configure the
a `org.apache.cassandra.sidecar.common.JmxClient`. This client is available as 
part of the Cassandra
delegate.

A new interface is introduced and exposed through the 
`org.apache.cassandra.sidecar.common.ICassandraAdapter`.
The new interface `StorageOperations` is intended to interface with the 
Cassandra StorageService.
This commit provides an example implementation of the `takeSnapshot` method, 
which is also found
in the Cassandra code base. This should allow us to interact with the Cassandra 
process to create
snapshots.

A fix is required in the `CassandraSidecarDaemon` class, where the 
`healthCheck` runs the first time
only after the configured health check frequency (millis) has passed. This 
causes issues in the unit
tests as well as the actual execution of the service, as the `adapter` will be 
`null` until the first
health check is performed. To fix this issue, we perform a health check right 
after the server
successfully starts up.

Additional integration tests are added for testing the JMX integration with 
Cassandra. In the test,
we spin up a new Cassandra container using `testcontainers` and we perform 
validation against the
StorageService in Cassandra.

Co-authored-by: Doug Rohrer <[email protected]>

patch by Francisco Guerrero, Doug Rohrer; reviewed by Yifan Cai, Dinesh Joshi 
for CASSANDRASC-47


> Introduce JMX foundation in Sidecar
> -----------------------------------
>
>                 Key: CASSANDRASC-47
>                 URL: https://issues.apache.org/jira/browse/CASSANDRASC-47
>             Project: Sidecar for Apache Cassandra
>          Issue Type: Improvement
>          Components: Rest API
>            Reporter: Francisco Guerrero
>            Assignee: Francisco Guerrero
>            Priority: Normal
>              Labels: pull-request-available
>
> Currently, Sidecar supports CQL access to the Cassandra instances it manages. 
> However, JMX support is not available at the moment. We need to introduce the 
> JMX foundation in Sidecar to support additional interactions with Cassandra 
> instances that are not available through the CQL protocol.
> This ticket is intended for introducing the JMX foundation, that can later be 
> used for adding new functionality to Sidecar interactions with Cassandra 
> through JMX.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to