[
https://issues.apache.org/jira/browse/CASSANDRA-17998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640934#comment-17640934
]
Josh McKenzie commented on CASSANDRA-17998:
-------------------------------------------
By "next couple of days" I meant 27.
Comments left on the PR; looking solid! This is a pretty delicate section of
the codebase so I'm of the opinion we should err on the side of being clear and
explicit about intended usage of things as well as guardrail the objects from
misuse so there's a decent chunk of that in the review + some javadoccing.
Nothing major; some recommendations structurally to bring some of the class
modifications and new classes into symmetry with their structure and usage
paradigms.
> Mutation Serialization Caching
> ------------------------------
>
> Key: CASSANDRA-17998
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17998
> Project: Cassandra
> Issue Type: Improvement
> Components: Messaging/Internode
> Reporter: T Jake Luciani
> Assignee: T Jake Luciani
> Priority: Normal
> Fix For: 4.x
>
>
> A performance change that adds mutation serialization caching to avoid
> re-serializing the mutation for commitlog and nodes twice.
> * Cached serialization for storage proxy and local commitlog
> * Cached deserialization for messaging service and local commitlog
> This yields a non trivial perf gain (~7-10%) and latency drop (median)
> [https://tjake.github.io/other/cached-mutations-report.html]
>
> The cached buffer is stored by MessagingService version to avoid being used
> by differing nodes during upgrades.
> Also, It avoids caching mutations larger than a threshold to avoid GC issues.
>
> GH PR: https://github.com/apache/cassandra/pull/1954
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
