[ 
https://issues.apache.org/jira/browse/CASSANDRA-17869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17643541#comment-17643541
 ] 

Michael Semb Wever commented on CASSANDRA-17869:
------------------------------------------------

bq. versioning the build scripts separately and having a single repo that has 
multi-version support makes some logical sense that we'd lose if we put it 
in-tree.

This is a current pain-point. Different JDK versions, different test types, 
etc, is overhead in complexity that has no value that I'm aware of? There's 
also a lot of {{`git clone --depth 1 --single-branch …cassandra-builds }} we 
could be avoiding… 

The idea is per-branch scripts. Put in the {{.build/}} folder. 

bq. I think that is what we also do with the python upgrade tests?

Both upgrade test types already have in-place definitions of what versions can 
be, and are to be, upgraded from and to. So it makes sense to not enforce the 
JDK used at the test level, but via the build.xml (so we actually verify that 
there's a JDK in common that all upgrade paths can operate on).

{quote}
bq. Can we remove JAVA8_HOME and JAVA11_HOME from dtests script and image?
What is your idea?
{quote}

Well, in ci-cassandra.a.o there are no jdk11 python dtests run… (AFAIK?)

But… it's unclear to what the purpose of the JAVA8_HOME and JAVA11_HOME 
variables are for? Given the jdk used for the tests comes down the JAVA_HOME 
variable anyway, and building bc JAVA11_HOME doesn't happen anymore…

bq. So you won't have both applicable in one version. Or did I misunderstand 
the question?

Why have anything in trunk ? (There was a discussion about it recently, but i 
can't find it…)


> Add JDK17 option to cassandra-builds (build-scripts and jenkins dsl) and on 
> jenkins agents
> ------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-17869
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17869
>             Project: Cassandra
>          Issue Type: Task
>          Components: Build
>            Reporter: Michael Semb Wever
>            Priority: Normal
>
> Add JDK17 option to cassandra-builds build-scripts, they only currently 
> support options {{8}} and {{1}}.
> Add JDK17 to the matrix axes in the jenkins dsl.
> Ensure JDK17 is installed on all the jenkins agents.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to