[
https://issues.apache.org/jira/browse/CASSANDRA-18086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17644244#comment-17644244
]
Marianne Lyne Manaog edited comment on CASSANDRA-18086 at 12/7/22 9:32 AM:
---------------------------------------------------------------------------
I closed the Jira ticket
[18097|https://issues.apache.org/jira/browse/CASSANDRA-18097] to keep
everything related to this fix here and simplify the review process. The
related Git commit shas of the three patches are as follows:
#
Fixed 'wait' time to be in nanoseconds for consistency, and not in
microseconds: f09369df89abc136ee387726c3083e43bd1893b5
# Invert order of numbers to compute waitNanos in Clock.java:
2316c36a01d12f04960d4260391ee08669893685
# Tests to verify behaviour of ContentionStrategy backoff methods:
8ec9d77de6492189fdce92d4b09e9104c6626fae
was (Author: JIRAUSER297594):
I closed the Jira ticket 18097 to keep everything related to this fix here and
simplify the review process. The related Git commit shas of the three patches
are as follows:
#
Fixed 'wait' time to be in nanoseconds for consistency, and not in
microseconds: f09369df89abc136ee387726c3083e43bd1893b5
# Invert order of numbers to compute waitNanos in Clock.java:
2316c36a01d12f04960d4260391ee08669893685
# Tests to verify behaviour of ContentionStrategy backoff methods:
8ec9d77de6492189fdce92d4b09e9104c6626fae
> Bug fix for 'wait' time to be in nanoseconds for consistency instead of
> microseconds
> ------------------------------------------------------------------------------------
>
> Key: CASSANDRA-18086
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18086
> Project: Cassandra
> Issue Type: Bug
> Components: Feature/Lightweight Transactions
> Reporter: Marianne Lyne Manaog
> Assignee: Marianne Lyne Manaog
> Priority: Normal
> Fix For: 4.1.x, 4.x
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> While working on benchmarking Paxos improvements in OSS Cassandra,
> [~benedict] was asked to review the work and thus found that the wait time
> was input in microseconds but then output incorrectly in the
> ContentionStrategy.java file, i.e., by summing up a wait time in nanoseconds
> with another wait time in microseconds (two different units used mistakenly).
> So, Benedict suggested the fix whereby the output wait time was then enforced
> to be consistently in nanoseconds.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]