[
https://issues.apache.org/jira/browse/CASSANDRA-17992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17651001#comment-17651001
]
Ekaterina Dimitrova edited comment on CASSANDRA-17992 at 12/21/22 9:05 PM:
---------------------------------------------------------------------------
A few updates after I cleaned my JDK17 WIP branch and tested with different
versions etc:
* _bulkLoaderSuccessfullyStreamsOverSsl_ always fails with JDK17 - current and
newer Netty versions with the classCastException we mentioned
* _tls_test_ Python DTest is failing the same way with particular Netty
versions.
On further logging I can confirm that indeed [~benedict] is right it is
submarine :) When using JDK provider and not OpenSSL, the class cast exception
is there with JDK17, no matter of Netty Version.
So two things:
* I think the netty update can be finished without being blocked by the
mentioned problem
* we can go in a separate ticket addressing the classCastException and
considering whether there might be an option without using add-exports. Not
that I have a better idea at this very moment
I will prepare a patch for the current ticket and also have to finish reviewing
the list of changes between current and newest versions to ensure I did not
miss anything that CI didn't catch
was (Author: e.dimitrova):
A few updates after I cleaned try JDK17 WIP branch and tested with different
versions etc:
* _bulkLoaderSuccessfullyStreamsOverSsl_ always fails with JDK17 - current and
newer Netty versions with the classCastException we mentioned
* _tls_test_ Python DTest is failing the same way with particular Netty
versions.
On further logging I can confirm that indeed [~benedict] is right it is
submarine :) When using JDK provider and not OpenSSL, the class cast exception
is there with JDK17, no matter of Netty Version.
So two things:
* I think the netty update can be finished without being blocked by the
mentioned problem
* we can go in a separate ticket addressing the classCastException and
considering whether there might be an option without using add-exports. Not
that I have a better idea at this very moment
I will prepare a patch for the current ticket and also have to finish reviewing
the list of changes between current and newest versions to ensure I did not
miss anything that CI didn't catch
> Upgrade Netty on 4.x(current trunk)
> -----------------------------------
>
> Key: CASSANDRA-17992
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17992
> Project: Cassandra
> Issue Type: Task
> Components: Dependencies
> Reporter: Ekaterina Dimitrova
> Assignee: Ekaterina Dimitrova
> Priority: Low
> Fix For: 4.x
>
>
> I haven't been able to identify from the Netty docs which was the lowest
> version where JDK17 was added but we are about 40 versions behind in netty 4
> so I suspect we better update.
> We need to consider there was an issue with class cast exceptions when
> building with JDK17 with newer versions of netty (the newest available in
> March 2022). For the record, we didn't see those when running CI on JDK8 and
> JDK11. We also need to carefully revise the changes between the netty
> versions.
> Upgrading will cover also a fix in netty that was discussed in
> [this|https://the-asf.slack.com/archives/CK23JSY2K/p1665567660202989] ASF
> Slack thread.
> CC [~benedict] , [~aleksey]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
