[
https://issues.apache.org/jira/browse/CASSANDRA-11537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655020#comment-17655020
]
William Nguyen commented on CASSANDRA-11537:
--------------------------------------------
I created a PR here: [https://github.com/apache/cassandra/pull/2060.] I took
Paulo's suggestion to throw an error at the end of{{{} NodeProbe.connect(){}}},
but doing so I needed to initially not start the test with {{requireNetwork()}}
because it sets the initialized flag for {{{}StorageServiceMBean{}}}. Though
for this to work, I needed to call
{{Class.forName("org.apache.cassandra.service.StorageProxy")}} in the setup to
the test.
The test itself runs nodetool ring without the initialization set.
I also needed to update a series of nodetool tests to include
{{requireNetwork(),}} now that {{NodeProbe}} checks if it is initialized.
> Give clear error when certain nodetool commands are issued before server is
> ready
> ---------------------------------------------------------------------------------
>
> Key: CASSANDRA-11537
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11537
> Project: Cassandra
> Issue Type: Improvement
> Components: Legacy/Observability, Local/Startup and Shutdown
> Reporter: Edward Capriolo
> Assignee: William Nguyen
> Priority: Low
> Labels: lhf
> Time Spent: 10m
> Remaining Estimate: 0h
>
> As an ops person upgrading and servicing Cassandra servers, I require a more
> clear message when I issue a nodetool command that the server is not ready
> for it so that I am not confused.
> Technical description:
> If you deploy a new binary, restart, and issue nodetool
> scrub/compact/updatess etc you get unfriendly assertion. An exception would
> be easier to understand. Also if a user has turned assertions off it is
> unclear what might happen.
> {noformat}
> EC1: Throw exception to make it clear server is still in start up process.
> :~# nodetool upgradesstables
> error: null
> -- StackTrace --
> java.lang.AssertionError
> at org.apache.cassandra.db.Keyspace.open(Keyspace.java:97)
> at
> org.apache.cassandra.service.StorageService.getValidKeyspace(StorageService.java:2573)
> at
> org.apache.cassandra.service.StorageService.getValidColumnFamilies(StorageService.java:2661)
> at
> org.apache.cassandra.service.StorageService.upgradeSSTables(StorageService.java:2421)
> {noformat}
> EC1:
> Patch against 2.1 (branch)
> https://github.com/apache/cassandra/compare/trunk...edwardcapriolo:exception-on-startup?expand=1
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
