[ 
https://issues.apache.org/jira/browse/CASSANDRA-18193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17681389#comment-17681389
 ] 

Henrik Ingo commented on CASSANDRA-18193:
-----------------------------------------

I spent some hours on Wednesday high level eyeballing the diff against G* 
trunk, to form my own opinion of what I see. I might post something about that 
next week, but for now I just wanted to share a by-product that I found and 
according to Benedict could be something you want to uncomment before the merge?

https://github.com/apache/cassandra/blob/cep-15-accord/src/java/org/apache/cassandra/dht/Murmur3Partitioner.java#L240-L255

> Provide design and API documentation
> ------------------------------------
>
>                 Key: CASSANDRA-18193
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-18193
>             Project: Cassandra
>          Issue Type: Task
>          Components: Accord
>            Reporter: Jacek Lewandowski
>            Priority: Normal
>
> Would be great if we have at minimum:
> - white paper in a form of an AsciiDoc or Markdown somewhere in the project 
> tree
> - all interfaces and all methods in {{acccord.api}} have API docs explaining 
> the requirements for the implementations
> - enums and their values across the project are documented
> - interfaces, abstract classes, or classes that do not inherit from anything 
> in the project have at least some class level explanation
> Eventually, it would really awesome if concepts from the whitepaper are 
> somehow referenced in the code (or vice-versa). It would make it much easier 
> to understand the implementation and I believe it would improve reuse of this 
> project for external applications



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to