[ 
https://issues.apache.org/jira/browse/CASSANDRA-18211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17689768#comment-17689768
 ] 

Stefan Miklosovic commented on CASSANDRA-18211:
-----------------------------------------------

Thanks Jacek, I fully agree. We should centralize all snapshot logic under 
SnapshotManager so logic related to snapshots is done only through that 
globally. Fixing all sychronization issues without this centralization just 
begs for more problems in the future.

> Possible race between automatic and manual snapshot cleanup
> -----------------------------------------------------------
>
>                 Key: CASSANDRA-18211
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-18211
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Local/Snapshots
>            Reporter: Jacek Lewandowski
>            Assignee: Stefan Miklosovic
>            Priority: Normal
>             Fix For: 4.1.x, 4.x
>
>
> Automatic deletion of expired snapshots maintained by {{SnapshotManager}} can 
> race with manual snapshot removal in a way an exception like 
> {{NoSuchFileException}} is thrown. 
> It is because the snapshot directory existence is checked and deleted if it 
> exists as a non-atomic operation. Since we can potentially have two threads 
> attempting to do that at the same time (automatic and manual snapshot 
> removal) it may lead to a race in rare situations.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to