[
https://issues.apache.org/jira/browse/CASSANDRA-18106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17690790#comment-17690790
]
Michael Semb Wever commented on CASSANDRA-18106:
------------------------------------------------
{quote}
Please check here, 8 passes with 11:
https://app.circleci.com/pipelines/github/driftx/cassandra/863/workflows/7fde3481-a4fe-4dc3-87a5-85efe0444910/jobs/12336/steps
{quote}
{noformat}
20:57:31,597 ccm INFO node1: current_java_version=8,
current_java_home_version=8, jvm_version=None, for_build=False,
cassandra_version=4.2, install_dir=/home/cassandra/cassandra,
env={'CIRCLE_WORKFLOW_JOB_ID': '5b542db9-b7e6-4dc1-a777-17c39954de86',
'PYTHONUNBUFFERED': 'true', 'JDK_HOME': '/usr/lib/jvm/java-8-openjdk-amd64',
'CASS_DRIVER_NO_CYTHON': 'true', 'REPEATED_UTESTS_STRESS': '<nil>',
'REPEATED_ANT_TEST_CLASS': '<nil>', 'HOSTNAME': 'de4e43665ea0',
'REPEATED_JVM_UPGRADE_DTESTS_COUNT': '500', 'REPEATED_UTESTS_COUNT': '500',
'REPEATED_UTESTS_LONG_COUNT': '100', 'JAVA_HOME':
'/usr/lib/jvm/java-8-openjdk-amd64', 'SSH_AUTH_SOCK':
'/tmp/circleci-2863131836/ssh_auth_sock', 'CIRCLE_REPOSITORY_URL':
'[email protected]:driftx/cassandra.git', 'CASS_DRIVER_NO_EXTENSIONS': 'true',
'REPEATED_UTESTS_LONG': '<nil>', 'CIRCLE_WORKING_DIRECTORY': '~/',
'CIRCLE_INTERNAL_CONFIG': '/.circleci-runner-config.json', 'CIRCLECI': 'true',
'REPEATED_DTESTS_COUNT': '500', 'CCM_HEAP_NEWSIZE': '256M',
'CASSANDRA_SKIP_SYNC': 'true', 'ANT_HOME': '/usr/share/ant',
'CIRCLE_PROJECT_REPONAME': 'cassandra', 'SPLIT_TESTS':
'compression_test.py::TestCompression::test_compression_cql_disabled_with_alter
cqlsh_tests/test_cqlsh.py::TestCqlsh::test_describe_describes_non_default_compaction_parameters
cqlsh_tests/test_cqlsh.py::TestCqlshUnicode::test_cqlsh_file_cmdline
cqlsh_tests/test_cqlsh_copy.py::TestCqlshCopy::test_reading_max_insert_errors
', 'REPEATED_LARGE_DTESTS_COUNT': '100', 'JAVA8_HOME':
'/usr/lib/jvm/java-8-openjdk-amd64', 'PWD': '/home/cassandra/cassandra-dtest',
'CQLSH_PYTHON': '/usr/bin/python3.8', 'REPEATED_UTESTS_FQLTOOL': '<nil>',
'CIRCLE_WORKFLOW_ID': '7fde3481-a4fe-4dc3-87a5-85efe0444910',
'REPEATED_JVM_DTESTS': '<nil>', 'KEEP_TEST_DIR': 'true',
'REPEATED_ANT_TEST_TARGET': 'testsome', 'CIRCLE_USERNAME': 'driftx',
'DTEST_REPO': 'https://github.com/driftx/cassandra-dtest.git',
'REPEATED_UPGRADE_DTESTS': '<nil>', 'CIRCLE_BRANCH': 'CASSANDRA-18106-trunk',
'DEFAULT_DIR': '/home/cassandra/cassandra-dtest', 'HOME': '/home/cassandra',
'LANG': 'en_US.UTF-8', 'VIRTUAL_ENV': '/home/cassandra/env3.8',
'CIRCLE_PROJECT_USERNAME': 'driftx', 'CIRCLE_BUILD_NUM': '12336',
'REPEATED_TESTS_STOP_ON_FAILURE': 'false', 'REPEATED_SIMULATOR_DTESTS_COUNT':
'500', 'JAVA11_HOME': '/usr/lib/jvm/java-11-openjdk-amd64',
'CIRCLE_NODE_TOTAL': '50', 'REPEATED_ANT_TEST_VNODES': 'false',
'REPEATED_DTESTS': '<nil>', 'CIRCLE_SHA1':
'ce8134b0cccfbd4a20d9e235f5a8818a91acf95d', 'REPEATED_ANT_TEST_COUNT': '500',
'NO_PROXY': '127.0.0.1,localhost,circleci-internal-outer-build-agent',
'PYTHONIOENCODING': 'utf-8', 'SHLVL': '0', 'CIRCLE_BUILD_URL':
'https://circleci.com/gh/driftx/cassandra/12336', 'BASH_ENV':
'/tmp/.bash_env-63efe9fd3252f1288bc39f49-0-build', 'REPEATED_JVM_DTESTS_COUNT':
'500', 'REPEATED_UTESTS': '<nil>', 'REPEATED_UTESTS_FQLTOOL_COUNT': '500',
'CIRCLE_NODE_INDEX': '0', 'REPEATED_JVM_UPGRADE_DTESTS': '<nil>',
'REPEATED_UTESTS_STRESS_COUNT': '500', 'REPEATED_ANT_TEST_METHODS': '<nil>',
'CIRCLE_WORKFLOW_WORKSPACE_ID': '7fde3481-a4fe-4dc3-87a5-85efe0444910',
'DTEST_BRANCH': 'CASSANDRA-18106', 'CIRCLE_JOB': 'j8_cqlsh_dtests_py38', 'PS1':
'(env3.8) ', 'REPEATED_UPGRADE_DTESTS_COUNT': '25', 'CIRCLE_SHELL_ENV':
'/tmp/.bash_env-63efe9fd3252f1288bc39f49-0-build', 'CCM_MAX_HEAP_SIZE':
'1024M', 'PATH':
'/usr/lib/jvm/java-8-openjdk-amd64/bin:/home/cassandra/env3.8/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin',
'CIRCLE_INTERNAL_SCRATCH': '/tmp/circleci-2863131836', 'CI': 'true',
'CIRCLE_INTERNAL_TASK_DATA':
'/tmp/.circleci-task-data-63efe9fd3252f1288bc39f49-0-build',
'REPEATED_LARGE_DTESTS': '<nil>', 'REPEATED_SIMULATOR_DTESTS': '<nil>',
'OLDPWD': '/home/cassandra/cassandra-dtest', '_':
'/home/cassandra/env3.8/bin/pytest', 'PYTEST_CURRENT_TEST':
'compression_test.py::TestCompression::test_compression_cql_disabled_with_alter
(call)', 'CASSANDRA_INCLUDE':
'/tmp/dtest-nhq_jsqs/test/node1/bin/cassandra.in.sh', 'MAX_HEAP_SIZE': '1024M',
'HEAP_NEWSIZE': '256M', 'CASSANDRA_HOME': '/home/cassandra/cassandra',
'CASSANDRA_CONF': '/tmp/dtest-nhq_jsqs/test/node1/conf'}
20:57:31,597 ccm INFO node1: using Java 11 for the current invocation
20:57:31,698 ccm INFO node1: current_java_version=8,
current_java_home_version=11, jvm_version=None, for_build=False,
cassandra_version=4.2, install_dir=/home/cassandra/cassandra,
env={'CIRCLE_WORKFLOW_JOB_ID': '5b542db9-b7e6-4dc1-a777-17c39954de86',
'PYTHONUNBUFFERED': 'true', 'JDK_HOME': '/usr/lib/jvm/java-8-openjdk-amd64',
'CASS_DRIVER_NO_CYTHON': 'true', 'REPEATED_UTESTS_STRESS': '<nil>',
'REPEATED_ANT_TEST_CLASS': '<nil>', 'HOSTNAME': 'de4e43665ea0',
'REPEATED_JVM_UPGRADE_DTESTS_COUNT': '500', 'REPEATED_UTESTS_COUNT': '500',
'REPEATED_UTESTS_LONG_COUNT': '100', 'JAVA_HOME':
'/usr/lib/jvm/java-11-openjdk-amd64', 'SSH_AUTH_SOCK':
'/tmp/circleci-2863131836/ssh_auth_sock', 'CIRCLE_REPOSITORY_URL':
'[email protected]:driftx/cassandra.git', 'CASS_DRIVER_NO_EXTENSIONS': 'true',
'REPEATED_UTESTS_LONG': '<nil>', 'CIRCLE_WORKING_DIRECTORY': '~/',
'CIRCLE_INTERNAL_CONFIG': '/.circleci-runner-config.json', 'CIRCLECI': 'true',
'REPEATED_DTESTS_COUNT': '500', 'CCM_HEAP_NEWSIZE': '256M',
'CASSANDRA_SKIP_SYNC': 'true', 'ANT_HOME': '/usr/share/ant',
'CIRCLE_PROJECT_REPONAME': 'cassandra', 'SPLIT_TESTS':
'compression_test.py::TestCompression::test_compression_cql_disabled_with_alter
cqlsh_tests/test_cqlsh.py::TestCqlsh::test_describe_describes_non_default_compaction_parameters
cqlsh_tests/test_cqlsh.py::TestCqlshUnicode::test_cqlsh_file_cmdline
cqlsh_tests/test_cqlsh_copy.py::TestCqlshCopy::test_reading_max_insert_errors
', 'REPEATED_LARGE_DTESTS_COUNT': '100', 'JAVA8_HOME':
'/usr/lib/jvm/java-8-openjdk-amd64', 'PWD': '/home/cassandra/cassandra-dtest',
'CQLSH_PYTHON': '/usr/bin/python3.8', 'REPEATED_UTESTS_FQLTOOL': '<nil>',
'CIRCLE_WORKFLOW_ID': '7fde3481-a4fe-4dc3-87a5-85efe0444910',
'REPEATED_JVM_DTESTS': '<nil>', 'KEEP_TEST_DIR': 'true',
'REPEATED_ANT_TEST_TARGET': 'testsome', 'CIRCLE_USERNAME': 'driftx',
'DTEST_REPO': 'https://github.com/driftx/cassandra-dtest.git',
'REPEATED_UPGRADE_DTESTS': '<nil>', 'CIRCLE_BRANCH': 'CASSANDRA-18106-trunk',
'DEFAULT_DIR': '/home/cassandra/cassandra-dtest', 'HOME': '/home/cassandra',
'LANG': 'en_US.UTF-8', 'VIRTUAL_ENV': '/home/cassandra/env3.8',
'CIRCLE_PROJECT_USERNAME': 'driftx', 'CIRCLE_BUILD_NUM': '12336',
'REPEATED_TESTS_STOP_ON_FAILURE': 'false', 'REPEATED_SIMULATOR_DTESTS_COUNT':
'500', 'JAVA11_HOME': '/usr/lib/jvm/java-11-openjdk-amd64',
'CIRCLE_NODE_TOTAL': '50', 'REPEATED_ANT_TEST_VNODES': 'false',
'REPEATED_DTESTS': '<nil>', 'CIRCLE_SHA1':
'ce8134b0cccfbd4a20d9e235f5a8818a91acf95d', 'REPEATED_ANT_TEST_COUNT': '500',
'NO_PROXY': '127.0.0.1,localhost,circleci-internal-outer-build-agent',
'PYTHONIOENCODING': 'utf-8', 'SHLVL': '0', 'CIRCLE_BUILD_URL':
'https://circleci.com/gh/driftx/cassandra/12336', 'BASH_ENV':
'/tmp/.bash_env-63efe9fd3252f1288bc39f49-0-build', 'REPEATED_JVM_DTESTS_COUNT':
'500', 'REPEATED_UTESTS': '<nil>', 'REPEATED_UTESTS_FQLTOOL_COUNT': '500',
'CIRCLE_NODE_INDEX': '0', 'REPEATED_JVM_UPGRADE_DTESTS': '<nil>',
'REPEATED_UTESTS_STRESS_COUNT': '500', 'REPEATED_ANT_TEST_METHODS': '<nil>',
'CIRCLE_WORKFLOW_WORKSPACE_ID': '7fde3481-a4fe-4dc3-87a5-85efe0444910',
'DTEST_BRANCH': 'CASSANDRA-18106', 'CIRCLE_JOB': 'j8_cqlsh_dtests_py38', 'PS1':
'(env3.8) ', 'REPEATED_UPGRADE_DTESTS_COUNT': '25', 'CIRCLE_SHELL_ENV':
'/tmp/.bash_env-63efe9fd3252f1288bc39f49-0-build', 'CCM_MAX_HEAP_SIZE':
'1024M', 'PATH':
'/usr/lib/jvm/java-11-openjdk-amd64/bin:/usr/lib/jvm/java-8-openjdk-amd64/bin:/home/cassandra/env3.8/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin',
'CIRCLE_INTERNAL_SCRATCH': '/tmp/circleci-2863131836', 'CI': 'true',
'CIRCLE_INTERNAL_TASK_DATA':
'/tmp/.circleci-task-data-63efe9fd3252f1288bc39f49-0-build',
'REPEATED_LARGE_DTESTS': '<nil>', 'REPEATED_SIMULATOR_DTESTS': '<nil>',
'OLDPWD': '/home/cassandra/cassandra-dtest', '_':
'/home/cassandra/env3.8/bin/pytest', 'PYTEST_CURRENT_TEST':
'compression_test.py::TestCompression::test_compression_cql_disabled_with_alter
(call)', 'CASSANDRA_INCLUDE':
'/tmp/dtest-nhq_jsqs/test/node1/bin/cassandra.in.sh', 'MAX_HEAP_SIZE': '1024M',
'HEAP_NEWSIZE': '256M', 'CASSANDRA_HOME': '/home/cassandra/cassandra',
'CASSANDRA_CONF': '/tmp/dtest-nhq_jsqs/test/node1/conf',
'CASSANDRA_LIBJEMALLOC': '-', 'JVM_EXTRA_OPTS': '
-Dcassandra.migration_task_wait_in_seconds=2'}
20:57:31,699 ccm INFO node1: using Java 11 for the current invocation
20:57:31,741 ccm INFO Starting node1 with
JAVA_HOME=/usr/lib/jvm/java-11-openjdk-amd64 java_version=8
cassandra_version=4.2, install_dir=/home/cassandra/cassandra
{noformat}
Oh, java.supported is providing "1.8" instead of just "8.
{code}
<property name="java.supported" value="1.8,11,17" />
{code}
https://github.com/driftx/cassandra/blob/CASSANDRA-18106-trunk/build.xml#L47
In common.py:: get_supported_jdk_versions can you strip the leading "1.", like
we also do in JdkProperties:
https://github.com/apache/cassandra/commit/d7352209b214559cea944b5df564b653a3379e3a#diff-9a83d3b5c7d2f3fbd1688f184201fe8b64d80935943ff359e0de69f80917f869R30
Also, trivial, but can we remove the JAVAx_HOME lines (in just trunk):
https://github.com/apache/cassandra/blob/trunk/.circleci/config.yml#L7971-L7972
> Update CCM for JDK17 and revise current JDK detection strategy
> --------------------------------------------------------------
>
> Key: CASSANDRA-18106
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18106
> Project: Cassandra
> Issue Type: Task
> Components: CI
> Reporter: Ekaterina Dimitrova
> Assignee: Brandon Williams
> Priority: Normal
> Fix For: 4.x
>
>
> As part of CASSANDRA-16895 initial POC an initial version of CCM patch was
> created. This needs to be revisited and reviewed
> Recently we closed CASSANDRA-18039 which brought questions, probably we need
> to revise how we detect JDK versions in CCM and whether it is correct. To the
> best of my knowledge there are certain tests in the repo around that and they
> pass so my guess is we need to revise just the strategy and maybe document it
> explicitly or consider if we want any changes to be applied. Also, we need to
> be careful with breaking changes.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
