[
https://issues.apache.org/jira/browse/CASSANDRA-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694067#comment-17694067
]
Stefan Miklosovic commented on CASSANDRA-18268:
-----------------------------------------------
I took a look into the patch [~milan_k] provided. Milan, what do you think
about doing the logging directly in "parallelAllSSTableOperation" method in
CompactionManager. Before the method call of "cfs.withAllSSTables" and after it
is done, before we call "return"? All operations in compaction manager go
through this method so we would not cover cleanup / gc only as suggested by
Brandon. It would be nice to write there "AllSSTableOpStatus" value as well,
when it is done.
> Log completed status with cleanup and garbagecollect operations
> ---------------------------------------------------------------
>
> Key: CASSANDRA-18268
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18268
> Project: Cassandra
> Issue Type: Improvement
> Components: Observability/Logging
> Reporter: Kan Maung
> Assignee: Milan Krisko
> Priority: Normal
>
> Whenever a cleanup or garbagecollect operation is issued from nodetool, there
> is no log statuses for the start and end of the operation at the node level
> although statuses on individual sstables are captured. Start can be inferred,
> but it is difficult to know when the operation has completed because there is
> no log message.
>
> [INFO ] cluster_id=5 ip_address=127.1.1.1 CompactionManager.java:353 -
> Starting Remove deleted data for keyspace1.sstable1
> [INFO ] cluster_id=5 ip_address=127.1.1.1 CompactionManager.java:395 -
> Finished Remove deleted data for keyspace1.sstable1 successfully
> [INFO ] cluster_id=5 ip_address=127.1.1.1 CompactionManager.java:353 -
> Starting Remove deleted data for keyspace1.sstable2
> [INFO ] cluster_id=5 ip_address=127.1.1.1 CompactionManager.java:364 - No
> sstables to GARBAGE_COLLECT for keyspace1.sstable2
> [INFO ] cluster_id=5 ip_address=127.1.1.1 CompactionManager.java:395 -
> Finished Remove deleted data for keyspace1.sstable2 successfully
>
> This improvement proposes adding additional for start and end statuses log
> messages for the above operation at the node level. I.e.,
>
> [INFO ] cluster_id=5 ip_address=127.1.1.1 CompactionManager.java:395 –
> Starting GARBAGE_COLLECT
> ….
> [INFO ] cluster_id=5 ip_address=127.1.1.1 CompactionManager.java:395 –
> Completed GARBAGE_COLLECT
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
