[
https://issues.apache.org/jira/browse/CASSANDRA-18332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17700765#comment-17700765
]
Josh McKenzie commented on CASSANDRA-18332:
-------------------------------------------
||Item|Link|
|PR|[link|https://github.com/apache/cassandra/pull/2219]|
|JDK8
CI|[link|https://app.circleci.com/pipelines/github/jmckenzie-dev/cassandra/334/workflows/4aad53f0-a6e6-407b-ace3-668b5f0db512]|
|JDK11
CI|[link|https://app.circleci.com/pipelines/github/jmckenzie-dev/cassandra/334/workflows/dfc6f82d-18d0-45cb-8a98-a982a0259da0]|
[~benedict] - almost identical to the 4.1+ patch (CASSANDRA-17205) with the
following 2 changes:
1) Ordering on constructor of checking for illegal state on {{parentRef}} to
immediately after acquisition rather than after initializing the {{Counter}}
potentially unnecessarily
2) Up log level from {{warn}} to {{error}} on {{StrongLeakDetector.run}}
Any chance you have a few minutes to glance over it on review? I'll pull it
forward with just the logging changes on merge up; since it's a 1 token log
level change I'm not too concerned about re-running CI for that if you're good
with it.
> Backport CASSANDRA-17205 to 4.0 branch (strong ref leak)
> --------------------------------------------------------
>
> Key: CASSANDRA-18332
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18332
> Project: Cassandra
> Issue Type: Bug
> Components: Local/SSTable
> Reporter: Josh McKenzie
> Assignee: Josh McKenzie
> Priority: Normal
> Fix For: 4.0.x
>
>
> See description in CASSANDRA-17205; this should have been applied on 4.0 and
> merged up but was overlooked.
>
> Also double-check that strong leaks are logged at ERROR instead of WARN on
> both 4.0, 4.1, and trunk (see
> [comment|https://issues.apache.org/jira/browse/CASSANDRA-18176?focusedCommentId=17687184&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17687184])
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
