[
https://issues.apache.org/jira/browse/CASSANDRA-18247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17701283#comment-17701283
]
Brandon Williams commented on CASSANDRA-18247:
----------------------------------------------
bq. Why I chose to do it that way? - I believe this will make it easy when the
time to switch to 11+17 come.
Seeing this in the review, my gut was to get rid of the repetition but it does
make sense and I agree with your choice. It will be much easier to rename
generate_11_and_17.sh to generate.sh when we are ready for the switch.
The readme made sense and I was able to follow it just fine, but I have a
little bit of previous experience here. One thing though, why make us copy
config_11_and_17.yml over config.yml instead of doing it like generate.sh does
and handling config.yml in the script? I think if I'm running the script to
generate that config it's probably what I'm going to use most of the time, and
if I need to go back I can just run generate.sh over it.
Everything else here looks good and I am generally +1.
> Add CircleCI config files for J11+J17
> -------------------------------------
>
> Key: CASSANDRA-18247
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18247
> Project: Cassandra
> Issue Type: Task
> Components: CI
> Reporter: Ekaterina Dimitrova
> Assignee: Ekaterina Dimitrova
> Priority: Normal
> Fix For: 5.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Based on the direction of [this
> discussion|https://lists.apache.org/thread/hchv59c1sntgb74clynj0zfd8jvwdmgy],
> I would like to propose CircleCI config files which can be used to test
> current trunk with JDK 17 (after I blindly remove the scripted UDFs in
> another ticket, to be opened soon)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
