[
https://issues.apache.org/jira/browse/CASSANDRA-18366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17705432#comment-17705432
]
Stefan Miklosovic edited comment on CASSANDRA-18366 at 3/27/23 4:21 PM:
------------------------------------------------------------------------
I am not able to fix this. What I have is this: (1)
In 4.0, the logic around "catching exceptions" is pretty much broken. This
stuff (2) is not called at all. The problem is that when InstanceShutdown is
thrown in InstanceKiller, it is actually never caught by anything. The patch in
(1) locally passes 5 out of 6 tests, the last one always fails on
"OutOfMemory". It seems like we are not cleaning up after test is finished
properly and it just crushes at the end on not enough memory.
(1)
https://github.com/instaclustr/cassandra/commit/290c44a9fcc8270511ecf9e18b7c11dc4f891c47
(2)
https://github.com/apache/cassandra/blob/trunk/test/distributed/org/apache/cassandra/distributed/test/FailingRepairTest.java#L149
[~dcapwell] any hint would be highly appreciated! I see you were touching some
before / after / waiting stuff lastly in this test in CASSANDRA-15332 or
CASSANDRA-17116 but it was never done to 4.0.
was (Author: smiklosovic):
I am not able to fix this. What I have is this: (1)
In 4.0, the logic around "catching exceptions" is pretty much broken. This
stuff (2) is not called at all. The problem is that when InstanceShutdown is
thrown in InstanceKiller, it is actually never caught by anything. The patch in
(1) locally passes 5 out of 6 tests, the last one always fails on
"OutOfMemory". It seems like we are not cleaning up after test is finished
properly and it just crushes at the end on not enough memory.
(1)
https://github.com/instaclustr/cassandra/commit/290c44a9fcc8270511ecf9e18b7c11dc4f891c47
(2)
https://github.com/apache/cassandra/blob/trunk/test/distributed/org/apache/cassandra/distributed/test/FailingRepairTest.java#L149
[~dcapwell] any hint would be highly appreciated! I see you were touching some
before / after / waiting stuff lastly in this patch in CASSANDRA-15332 or
CASSANDRA-17116 but it was never done to 4.0.
> Test failure: org.apache.cassandra.distributed.test.FailingRepairTest -
> testFailingMessage[VALIDATION_REQ/parallel/true]
> ------------------------------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-18366
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18366
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/java
> Reporter: Brandon Williams
> Priority: Normal
> Fix For: 4.0.x
>
>
> First seen
> [here|https://app.circleci.com/pipelines/github/driftx/cassandra/928/workflows/f4e93a72-d4aa-47a2-996f-aa3fb018d848/jobs/16206]
> this test times out for me consistently on both j8 and j11 where 4.1 and
> trunk do not.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
