[ 
https://issues.apache.org/jira/browse/CASSANDRA-18332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17707593#comment-17707593
 ] 

Josh McKenzie edited comment on CASSANDRA-18332 at 4/1/23 10:58 PM:
--------------------------------------------------------------------

bq. If I understand it correctly, this has to go to 4.0 and then the changes in 
constructor on that parentRef order as well as logging from warn to error level 
should be applied to 4.1 and trunk, right?
Correct. The logging level change is material and the other is more or less 
just trivial hygiene.

Edit: looks like just 1 flake on both 
[JDK8|https://app.circleci.com/pipelines/github/instaclustr/cassandra/2044/workflows/80d2d0e8-6253-43af-b90f-d75c8cb05726/jobs/18359/tests]
 and 
[JDK11|https://app.circleci.com/pipelines/github/instaclustr/cassandra/2044/workflows/0b2d215a-8de2-4f69-8b67-314a0eb04bc4/jobs/18335/tests],
 same test.

I'll circle back to that test on Monday and see how it holds up under clean 
multiplexing on 4.0 on circle; if it's got issues I'll go ahead and create a 
JIRA for it.

You good w/me going through merge up process Monday otherwise [~smiklosovic]?


was (Author: jmckenzie):
bq. If I understand it correctly, this has to go to 4.0 and then the changes in 
constructor on that parentRef order as well as logging from warn to error level 
should be applied to 4.1 and trunk, right?
Correct. The logging level change is material and the other is more or less 
just trivial hygiene.

> Backport CASSANDRA-17205 to 4.0 branch (strong ref leak)
> --------------------------------------------------------
>
>                 Key: CASSANDRA-18332
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-18332
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Local/SSTable
>            Reporter: Josh McKenzie
>            Assignee: Josh McKenzie
>            Priority: Normal
>             Fix For: 4.0.x
>
>
> See description in CASSANDRA-17205; this should have been applied on 4.0 and 
> merged up but was overlooked.
>  
> Also double-check that strong leaks are logged at ERROR instead of WARN on 
> both 4.0, 4.1, and trunk (see 
> [comment|https://issues.apache.org/jira/browse/CASSANDRA-18176?focusedCommentId=17687184&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17687184])



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to