[
https://issues.apache.org/jira/browse/CASSANDRA-18239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17711145#comment-17711145
]
Ekaterina Dimitrova commented on CASSANDRA-18239:
-------------------------------------------------
{quote}It may end up with SpotBugs ([~mmuzaf] your summary is very useful). We
can use Sonar but it seems like it cannot be considered as a strict replacement
of Eclipse-Warnings as the way how we would have to use it is completely
different.
We can try adding it SpotBugs task in Ant script for now and see how it works.
{quote}
[~jlewandowski] , [~mmuzaf] I am working on *CASSANDRA-18190* and I took a
quick look at SpotBugs - I did not manage to find any checks around
AutoCloseable? Did you see anything? Maybe I am missing something as they are
too many. In that sense I do not see it still as a replacement for
eclipse-warnings (I believe we agreed Sonar can also not replace the
eclipse-warnings so I guess it is time to change the ticket title and
description?)
> Replace eclipse warnings based static code analysis with something better
> (Sonar)
> ---------------------------------------------------------------------------------
>
> Key: CASSANDRA-18239
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18239
> Project: Cassandra
> Issue Type: Task
> Components: Build
> Reporter: Jacek Lewandowski
> Priority: Normal
>
> Eclipse warnings is used for static code analysis. However, it does not fit
> well into Cassandra code and practically we end up explicitly adding
> suppressions in many places just to satisfy that tool rather than fix the
> real issues.
> This is an incomplete list of reasons to remove it:
> - not closed resources are detected incorrectly
> - does not recognize custom utility methods used to close the resources,
> which use use heavily in the code, like {{Throwables.close}},
> {{FileUtils.close}}, {{closeQuietly}}...
> - because of the above, we cannot make important things like {{Ref}} to
> implement {{Closeable}} as it would make the tool to explode with tons of
> warnings
> - it complains about correct generics - something like "method X is not
> applicable for ..." when the code compiles successfully is not acceptable
> - it is old and not maintained
> There are better tools like IntelliJ inspections for example, which can also
> be run in headless mode
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
