[
https://issues.apache.org/jira/browse/CASSANDRA-12937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17714856#comment-17714856
]
Claude Warren edited comment on CASSANDRA-12937 at 4/21/23 1:57 PM:
--------------------------------------------------------------------
[~smiklosovic], [~mck]
Please review [Github Pull Request
#2254|https://github.com/apache/cassandra/pull/2254] there are a number of
changes.
* switched to ParameterizedClass for yaml configuration
* ensured processing to support CQL compression parameters
* added extensive yaml file documentation.
* moved methods used only in testing from CompressionParams to a new
TestingCompressionParamsFactory class.
* updated tests to use TestingCompressionFactory.
* added extensive testing to ensure that all combinations of Map and
ParameterizedClass construct the same CompressionParams.
* added additional testing coverage for pre-existing methods
* unified error reporting so that the same error on different paths reports
with the same text.
was (Author: claudenw):
[~smiklosovic], [~mck]
Please review [Github Pull Request
#2254|https://github.com/apache/cassandra/pull/2254] there are a number of
changes.
* switched to ParameterizedClass for yaml configuration
* ensured processing to support CQL compression parameters
* added extensive yaml file documentation.
* moved methods used only in testing from CompressionParams to a new
TestingCompressionParamsFactory class.
* updated tests to use TestingCompressionFactory.
* added extensive testing to ensure that all combinations of Map and
ParameterixedClass construct the same CompressionParams.
* added additional testing coverage or pre-existing methods
* unified error reporting so that the same error on different paths reports
with the same text.
> Default setting (yaml) for SSTable compression
> ----------------------------------------------
>
> Key: CASSANDRA-12937
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12937
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Config
> Reporter: Michael Semb Wever
> Assignee: Claude Warren
> Priority: Low
> Labels: AdventCalendar2021, lhf
> Fix For: 5.x
>
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> In many situations the choice of compression for sstables is more relevant to
> the disks attached than to the schema and data.
> This issue is to add to cassandra.yaml a default value for sstable
> compression that new tables will inherit (instead of the defaults found in
> {{CompressionParams.DEFAULT}}.
> Examples where this can be relevant are filesystems that do on-the-fly
> compression (btrfs, zfs) or specific disk configurations or even specific C*
> versions (see CASSANDRA-10995 ).
> +Additional information for newcomers+
> Some new fields need to be added to {{cassandra.yaml}} to allow specifying
> the field required for defining the default compression parameters. In
> {{DatabaseDescriptor}} a new {{CompressionParams}} field should be added for
> the default compression. This field should be initialized in
> {{DatabaseDescriptor.applySimpleConfig()}}. At the different places where
> {{CompressionParams.DEFAULT}} was used the code should call
> {{DatabaseDescriptor#getDefaultCompressionParams}} that should return some
> copy of configured {{CompressionParams}}.
> Some unit test using {{OverrideConfigurationLoader}} should be used to test
> that the table schema use the new default when a new table is created (see
> CreateTest for some example).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
