[
https://issues.apache.org/jira/browse/CASSANDRA-16855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17717776#comment-17717776
]
Stefan Miklosovic edited comment on CASSANDRA-16855 at 5/1/23 8:42 PM:
-----------------------------------------------------------------------
[https://github.com/apache/cassandra/pull/2297]
j8 pre-commit
[https://app.circleci.com/pipelines/github/instaclustr/cassandra/2159/workflows/c53de0ea-721f-4545-bb6d-761ff6e3f3f2|https://app.circleci.com/pipelines/github/instaclustr/cassandra/2161/workflows/a9c59579-04f6-490a-be97-8e0059d8a226]
j11 pre-commit
[https://app.circleci.com/pipelines/github/instaclustr/cassandra/2159/workflows/6c3d588e-fcb0-43e2-a493-ba4ffcc47d22|https://app.circleci.com/pipelines/github/instaclustr/cassandra/2161/workflows/02d6b1ee-7b7c-46e2-bc9f-55c862b28ff7]
edit: I changed the builds to point to the latest state of the branch, all
clean but one flake
was (Author: smiklosovic):
https://github.com/apache/cassandra/pull/2297
j8 pre-commit
[https://app.circleci.com/pipelines/github/instaclustr/cassandra/2159/workflows/c53de0ea-721f-4545-bb6d-761ff6e3f3f2]
j11 pre-commit
[https://app.circleci.com/pipelines/github/instaclustr/cassandra/2159/workflows/6c3d588e-fcb0-43e2-a493-ba4ffcc47d22]
> Replace minor use of `json-simple` with Jackson
> -----------------------------------------------
>
> Key: CASSANDRA-16855
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16855
> Project: Cassandra
> Issue Type: Improvement
> Components: Dependencies, Local/Other, Tool/nodetool
> Reporter: Tatu Saloranta
> Assignee: Stefan Miklosovic
> Priority: Normal
> Labels: pull-request-available
> Fix For: 5.x
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Jackson library is used for most JSON reading/writing, but there are couple
> of places where older "json-simple" library is used, mostly for diagnostics
> output. Replacing those minor usages would allow removal of a dependency, one
> for which the last release was made in 2012.
> Places where json-simple is used are:
> * src/java/org/apache/cassandra/db/ColumnFamilyStore.java
> * src/java/org/apache/cassandra/db/commitlog/CommitLogDescriptor.java
> * src/java/org/apache/cassandra/hints/HintsDescriptor.java
> * src/java/org/apache/cassandra/tools/nodetool/stats/StatsPrinter.java
> (and some matching usage in couple of test classes)
> I can take a stab at replacing these uses; it also looks like test coverage
> may be spotty for some (StatsPrinter json/yaml part has no tests for example).
> It is probably best to target this for "trunk" (4.1?).
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]