[
https://issues.apache.org/jira/browse/CASSANDRA-18467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17719269#comment-17719269
]
Ekaterina Dimitrova edited comment on CASSANDRA-18467 at 5/4/23 11:04 AM:
--------------------------------------------------------------------------
[~jakubzytka] helped me to figure out the issue. The Itellij Idea SDK had a few
options for JDK 11 and if it gets the wrong one which doesn't work, this
triggers the IDE to assign default JDK 17.
It seems we might also want to add a step or at least instruction to ask people
to remove .idea and .cassandra.iml before running *ant generate-idea-files.* It
seems also reasonable to stress in docs to pay attention to File -> Project
Structure -> SDK
With that said I tested that the currently proposed patch not only looks good
to me but also works as expected.
I triggered CI:
[8+11|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=CASSANDRA-18467],
[11+17|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=18467-JDK17]
was (Author: e.dimitrova):
[~jakubzytka] helped me to figure out the issue. The Itellij Idea SDK had a few
options for JDK 11 and if it gets the wrong one which doesn't work, this
triggers the IDE to assign default JDK 17.
It seems we might also want to add a step or at least instruction to ask people
to remove .idea and .cassandra.iml before running *ant generate-idea-files* and
pay attention to File -> Project Structure -> SDK
With that said I tested that the currently proposed patch not only looks good
to me but also works as expected.
I triggered CI:
[8+11|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=CASSANDRA-18467],
[11+17|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=18467-JDK17]
> Update generate-idea-files for J17
> ----------------------------------
>
> Key: CASSANDRA-18467
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18467
> Project: Cassandra
> Issue Type: Task
> Components: Build
> Reporter: Ekaterina Dimitrova
> Assignee: Jakub Zytka
> Priority: Low
> Fix For: 5.x
>
>
> There was a discussion in CASSANDRA-18258 how to update generate-idea-files.
> The final agreement was to create one target to cover both Java 11 and Java
> 17.
> It will be good to figure out CASSANDRA-18263 and reshuffle arguments and
> tasks based on what we decide to use as gc in testing for both Java 11 and
> Java 17.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
