[
https://issues.apache.org/jira/browse/CASSANDRA-18521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17722886#comment-17722886
]
Andres de la Peña edited comment on CASSANDRA-18521 at 5/15/23 5:44 PM:
------------------------------------------------------------------------
So far, the test failures are:
* {{InsertUpdateIfConditionTest#testMultiExistConditionOnSameRowClustering}} is
CASSANDRA-18287
* {{SelectiveIntersectionTest#tracingIsCorrectlyReported}} doesn't seem related
to the changes, but it might be worth to verify that it also exists on
{{cep-7-sai}}. Running it
[here|https://app.circleci.com/pipelines/github/adelapena/cassandra/2898/workflows/8c4deea8-fc65-475e-b7a0-7faaf8c3acaa].
* {{StorageAttachedIndexDDLTest#concurrentTruncateWithIndexBuilding}} can be
[reproduced on
{{cep-7-sai}}|https://app.circleci.com/pipelines/github/adelapena/cassandra/2894/workflows/71d2d463-2780-496d-a6fd-8c530768ae1b/jobs/44121/tests].
* {{TopPartitionsTest#testServiceTopPartitionsSingleTable}} is CASSANDRA-17798.
was (Author: adelapena):
So far, the test failures are:
* {{InsertUpdateIfConditionTest#testMultiExistConditionOnSameRowClustering}} is
CASSANDRA-18287
* {{SelectiveIntersectionTest#tracingIsCorrectlyReported}} doesn't seem related
to the changes, but it might be worth to verify that it also exists on
{{cep-7-sai}}.
* {{StorageAttachedIndexDDLTest#concurrentTruncateWithIndexBuilding}} can be
[reproduced on
{{cep-7-sai}}|https://app.circleci.com/pipelines/github/adelapena/cassandra/2894/workflows/71d2d463-2780-496d-a6fd-8c530768ae1b/jobs/44121/tests].
* {{TopPartitionsTest#testServiceTopPartitionsSingleTable}} is CASSANDRA-17798.
> Unify CQLTester#waitForIndex and SAITester#waitForIndexQueryable
> ----------------------------------------------------------------
>
> Key: CASSANDRA-18521
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18521
> Project: Cassandra
> Issue Type: Improvement
> Components: Feature/SAI
> Reporter: Andres de la Peña
> Assignee: Andres de la Peña
> Priority: Normal
> Fix For: NA
>
>
> It has been
> [mentioned|https://github.com/maedhroz/cassandra/pull/11#discussion_r1190166765]
> in CASSANDRA-18217 that {{CQLTester#waitForIndex}} and
> {{SAITester#waitForIndexQueryable}} can be unified into a single method.
> The same discussion mentions that it's easy to forget to call those methods
> after calling {{CQLTester#createIndex}}. So that method can be renamed to
> {{createIndexAsync}}, and we can create a new method that creates the index
> and waits for it ({{createIndexSync}}, {{createIndexAndWaitForQueryable}}, or
> something like that).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
