[
https://issues.apache.org/jira/browse/CASSANDRA-18453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17724377#comment-17724377
]
Stefan Miklosovic commented on CASSANDRA-18453:
-----------------------------------------------
[~bernardo.botella] would it be possible to update our checkstyle_test.xml so
the code you are fixing will not be valid anymore so people are not using this
"wrongly" ever again? We will probably need to be smart about this. Definitely
it is worth to look into this. It is one thing to clean it all up but the next
level is to disallow that to ever happen again.
> Use WithProperties to ensure that system properties are handled
> ---------------------------------------------------------------
>
> Key: CASSANDRA-18453
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18453
> Project: Cassandra
> Issue Type: Task
> Components: CI
> Reporter: Maxim Muzafarov
> Assignee: Bernardo Botella Corbi
> Priority: Normal
> Labels: low-hanging-fruit
> Fix For: 5.x
>
>
> The {{WithProperties}} is used to handle system properties to set and reset
> values during the test run, instead of try-catch it uses the
> try-with-resource approach which facilitates test development.
> We need to replace all the try-catch clauses that work with system properties
> with {{WithProperties}} and try-with-resource for all the similar cases and
> where it is technically possible.
> Example:
> {code:java}
> try
> {
> COMMITLOG_IGNORE_REPLAY_ERRORS.setBoolean(true);
> testRecoveryWithGarbageLog();
> }
> finally
> {
> COMMITLOG_IGNORE_REPLAY_ERRORS.clearValue();
> }
> {code}
> Can be replaced with:
> {code:java}
> try (WithProperties = new
> WithProperties().with(COMMITLOG_IGNORE_REPLAY_ERRORS, "true"))
> {
> testRecoveryWithGarbageLog();
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
