[
https://issues.apache.org/jira/browse/CASSANDRA-18453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17724379#comment-17724379
]
Stefan Miklosovic edited comment on CASSANDRA-18453 at 5/19/23 6:55 PM:
------------------------------------------------------------------------
You may say that ".clearValue();" is illegal to use in tests unless it is
explicitly allowed (there happens to be a commentary for this at the end of the
line). You need to look into checkstyle_test.xml to see it in action.
was (Author: smiklosovic):
You may say that "clearValue();" is illegal to use in tests unless it is
explicitly allowed (there happens to be a commentary for this at the end of the
line). You need to look into checkstyle_test.xml to see it in action.
> Use WithProperties to ensure that system properties are handled
> ---------------------------------------------------------------
>
> Key: CASSANDRA-18453
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18453
> Project: Cassandra
> Issue Type: Task
> Components: CI
> Reporter: Maxim Muzafarov
> Assignee: Bernardo Botella Corbi
> Priority: Normal
> Labels: low-hanging-fruit
> Fix For: 5.x
>
>
> The {{WithProperties}} is used to handle system properties to set and reset
> values during the test run, instead of try-catch it uses the
> try-with-resource approach which facilitates test development.
> We need to replace all the try-catch clauses that work with system properties
> with {{WithProperties}} and try-with-resource for all the similar cases and
> where it is technically possible.
> Example:
> {code:java}
> try
> {
> COMMITLOG_IGNORE_REPLAY_ERRORS.setBoolean(true);
> testRecoveryWithGarbageLog();
> }
> finally
> {
> COMMITLOG_IGNORE_REPLAY_ERRORS.clearValue();
> }
> {code}
> Can be replaced with:
> {code:java}
> try (WithProperties = new
> WithProperties().with(COMMITLOG_IGNORE_REPLAY_ERRORS, "true"))
> {
> testRecoveryWithGarbageLog();
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
