[
https://issues.apache.org/jira/browse/CASSANDRA-18542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17724922#comment-17724922
]
Stefan Miklosovic edited comment on CASSANDRA-18542 at 5/22/23 12:04 PM:
-------------------------------------------------------------------------
I would remove it from dtests and I would place it into cassandra repository
into pylib/cassandra-cqlsh-test.sh. It does just this
pycodestyle --ignore E501,E402,E731,W503 pylib/cqlshlib/*.py bin/cqlsh.py
There is some logic around it in dtest but I am not sure it needs to be so
complicated and what is the difference.
was (Author: smiklosovic):
I would remove it from dtests and I would place it into cassandra repository
under into pylib/cassandra-cqlsh-test.sh. It does just this
pycodestyle --ignore E501,E402,E731,W503 pylib/cqlshlib/*.py bin/cqlsh.py
There is some logic around it in dtest but I am not sure it needs to be so
complicated and what is the difference.
> Add a simple way to run pycodestyle checks
> ------------------------------------------
>
> Key: CASSANDRA-18542
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18542
> Project: Cassandra
> Issue Type: Improvement
> Components: Build
> Reporter: Brandon Williams
> Priority: Normal
> Fix For: 4.0.x, 4.1.x, 5.x
>
>
> As the title says. Basically I want to solve the problem of having perfectly
> valid good looking python, only push and have the dtests run pycodestyle and
> fail everything out for a missing blank line. We should have a convenient
> way to catch this sooner.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
