[
https://issues.apache.org/jira/browse/CASSANDRA-18453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17726672#comment-17726672
]
Stefan Miklosovic commented on CASSANDRA-18453:
-----------------------------------------------
j11
https://app.circleci.com/pipelines/github/instaclustr/cassandra/2309/workflows/c89b3963-7571-4373-aa6b-6bdfc8fcf729
j8
https://app.circleci.com/pipelines/github/instaclustr/cassandra/2309/workflows/f99b64ef-8e5d-4fbb-a050-c012039fa58e
failing tests were fixed in the meanwhile in upstream repo
+1
> Use WithProperties to ensure that system properties are handled
> ---------------------------------------------------------------
>
> Key: CASSANDRA-18453
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18453
> Project: Cassandra
> Issue Type: Task
> Components: CI
> Reporter: Maxim Muzafarov
> Assignee: Bernardo Botella Corbi
> Priority: Normal
> Labels: low-hanging-fruit
> Fix For: 5.x
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> The {{WithProperties}} is used to handle system properties to set and reset
> values during the test run, instead of try-catch it uses the
> try-with-resource approach which facilitates test development.
> We need to replace all the try-catch clauses that work with system properties
> with {{WithProperties}} and try-with-resource for all the similar cases and
> where it is technically possible.
> Example:
> {code:java}
> try
> {
> COMMITLOG_IGNORE_REPLAY_ERRORS.setBoolean(true);
> testRecoveryWithGarbageLog();
> }
> finally
> {
> COMMITLOG_IGNORE_REPLAY_ERRORS.clearValue();
> }
> {code}
> Can be replaced with:
> {code:java}
> try (WithProperties = new
> WithProperties().with(COMMITLOG_IGNORE_REPLAY_ERRORS, "true"))
> {
> testRecoveryWithGarbageLog();
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
