[ 
https://issues.apache.org/jira/browse/CASSANDRA-3001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093631#comment-13093631
 ] 

Sylvain Lebresne commented on CASSANDRA-3001:
---------------------------------------------

Patch rebased. I've included the change to the thrift generated files as a 
second patch for completeness.

bq. Is there a reason why code to copy compression parameters is duplicated all 
over the CFMetaData

Yes, the places where the code is "duplicated" are where a Map<CharSequence, 
CharSequence> is expected, while copyOptions returns a Map<String, String>. 
Still, we could have create a specific static method to avoid code duplication 
*but*, after rebasing, there remains only one occurrence of this.

bq. Documentation for CLI and stress wasn't updated to list DeflateCompressor

Updated documentation in the rebased patch. Stress was already updated: it 
requires specifying the compressor class after the -I option.

> Make the compression algorithm and chunk length configurable
> ------------------------------------------------------------
>
>                 Key: CASSANDRA-3001
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3001
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Sylvain Lebresne
>            Assignee: Sylvain Lebresne
>            Priority: Minor
>              Labels: compression
>             Fix For: 1.0
>
>         Attachments: 0001-Pluggable-algorithm-and-chunk-length.patch, 
> 0002-Thrift-crap.patch, 0003-Add-deflate-compressor.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to