[
https://issues.apache.org/jira/browse/CASSANDRA-18593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17732948#comment-17732948
]
Berenguer Blasi commented on CASSANDRA-18593:
---------------------------------------------
LGTM +1
> CircleCI: Add separate approval step for oa utests on separate workflows
> ------------------------------------------------------------------------
>
> Key: CASSANDRA-18593
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18593
> Project: Cassandra
> Issue Type: Bug
> Components: CI
> Reporter: Andres de la Peña
> Assignee: Andres de la Peña
> Priority: Normal
> Fix For: 5.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> CASSANDRA-14227 added new {{j*_utests_oa}} jobs to run unit tests with the
> new, not-default "oa" sstable format. Those tests depend on the
> {{start_j*_unit_tests}} approval step on the separate workflows.
> However, the separate workflow is meant to allow running jobs individually,
> and having a common approval step for both {{j*_unit_tests}} and
> {{j*_utests_oa}} prevents us from doing so. That's the case for example of
> the development of CASSANDRA-18504, where I want to run a single unit test
> job without caring about the specialization, but the common approval step
> forces me to run both jobs, duplicating the costs. An example run can be seen
> [here|https://app.circleci.com/pipelines/github/adelapena/cassandra/2948/workflows/67e5bfcd-c8df-4558-a889-c8828e8dd310].
> I think that {{j*_utests_oa}} should have its own separate approval step, the
> same way that {{{}j*_utest_cdc{}}}, {{{}j*_utest_fqltool{}}},
> {{j*_utest_compression}} or {{j*_utest_system_keyspace_directory}} have their
> own approval step.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
