[
https://issues.apache.org/jira/browse/CASSANDRA-18305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17734041#comment-17734041
]
Stefan Miklosovic edited comment on CASSANDRA-18305 at 6/19/23 7:40 AM:
------------------------------------------------------------------------
Thanks [[email protected]] for the changes.
The last thing I did to 4.0 branch is this (1).
Basically, we were using two TableBuilders instead of just one. I consolidated
this so all output is rendered into one table. I accommodated tests as well.
The patch is not applying cleanly to 4.1 so I took care of that too.
I am going to build 4.0 and 4.1 patches in CircleCI and I will let you know how
it goes. I think we have everything necessary to finish this.
https://github.com/instaclustr/cassandra/commit/1458de87d994cf5735dc452568556c54e2f6228e
was (Author: smiklosovic):
Thanks [[email protected]] for the changes.
The last thing I did to 4.0 branch is this (1).
Basically, we were using two TableBuilders instead of just one. I consolidated
this so all output is rendered into one table. I accommodated tests as well.
The patch is not applying cleanly from to 4.1 so I took care of that too.
I am going to build 4.0 and 4.1 patches in CircleCI and I will let you know how
it goes. I think we have everything necessary to finish this.
https://github.com/instaclustr/cassandra/commit/1458de87d994cf5735dc452568556c54e2f6228e
> Enhance nodetool compactionstats with existing MBean metrics
> ------------------------------------------------------------
>
> Key: CASSANDRA-18305
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18305
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/nodetool
> Reporter: Brad Schoening
> Assignee: Manish Ghildiyal
> Priority: Normal
> Fix For: 4.0.x, 4.1.x, 5.x
>
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> Nodetool compactionstats reports only on active compactions, if nothing is
> active, you see only:
> {quote}$nodetool compactionstats
> pending tasks: 0
> {quote}
> but in the MBean Compaction/TotalCompactionsCompleted there are recent
> statistic in events/second for:
> * Count
> * FifteenMinueRate
> * FiveMinueRate
> * MeanRate
> * OneMinuteRate
> 1) It would be useful to see in addition:
> {quote}pending tasks: 0
> compactions completed: 20
> 1 minute rate: 0/second
> 5 minute rate: 2.3/second
> 15 minute rate: 4.6/second
> {quote}
> 2) Since compaction_throughput_mb_per_sec is a throttling parameter in
> cassandra.yaml (default 64 MBps), it would be nice to show the actual
> compaction throughput and be able to observe if you're close to the limit.
> I.e.,
> {quote}compaction throughput 13.2 MBps / 16 MBps (82.5%)
> {quote}
> 3) for completness, compactionstats should list the number of concurrent
> compactors configured, perhaps simply add to existing 'pending tasks' line:
> {quote}4 concurrent compactors, 0 pending tasks
> {quote}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
