[
https://issues.apache.org/jira/browse/CASSANDRA-18017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17736102#comment-17736102
]
Michael Semb Wever commented on CASSANDRA-18017:
------------------------------------------------
bq. It is weird that target `testclasslist` depends on running `checkstyle`. I
think that we should simply fix the `build.xml` and then we would not need to
update the Jenkins scripts.
I agree that the checks and building should be separately invoked ant tasks.
Both should be easy to do locally, and encouraged to be done before push.
I've taken this approach in 18133, with the separate build-jar.sh and
check_code.sh scripts. (Both are just simple layers onto the equivalent ant
targets.
bq. I have been talking with Michael and he said that it's better to focus on
CASSANDRA-18133
I have no objection to the simple patch of separately out the checkstyle call
in build.xml
(my objection was only to patching the jenkins/build scripts, as that requires
time-consuming testing on a custom built jenkins installation)
> Jenkins: Consider using the no-build-test flag
> ----------------------------------------------
>
> Key: CASSANDRA-18017
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18017
> Project: Cassandra
> Issue Type: Task
> Components: CI
> Reporter: Andres de la Peña
> Assignee: Maxim Muzafarov
> Priority: Normal
> Time Spent: 10m
> Remaining Estimate: 0h
>
> CASSANDRA-16625 and CASSANDRA-18000 added a {{-Dno-build-test=true}} flag to
> skip the dependencies of the Ant test targets. This is useful to speed up the
> test targets if the {{build-test}} target has already been previously run,
> for example as part of {{{}ant jar{}}}.
> That was created thinking mainly on CircleCI's multiplexer, where we run the
> same test target repeatedly. Skipping the already run depended on targets can
> significantly speed up the tests. The flag however is also useful for all
> other test jobs because every parallel runner can skip the test building
> step, and we have hundreds of parallel runners. Saving around 30s on every
> runner adds up considerable savings.
> Maybe this flag can also be used for skipping test builds on Jenkins too, so
> each parallel test split can benefit from a slight boost. That could be done
> if either {{build-test}} or {{jar}} have already been run before calling the
> test target. I'm not familiarized with Jenkins config so I'm not sure whether
> it makes sense.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
