[ 
https://issues.apache.org/jira/browse/CASSANDRA-18582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17741727#comment-17741727
 ] 

Ekaterina Dimitrova commented on CASSANDRA-18582:
-------------------------------------------------

+1 if [~jonmeredith] has nothing to add here from his review and on green CI.
{quote}The {{EncryptionOptions.cipherSuitesArray}} method was returning an 
empty array when {{cipher_suites}} is {{{}null{}}}. However, something 
downstream of {{RemoteEndpointAwareJdkSSLOptions}} doesn't like an empty array 
- I'm not sure what, but just returning {{null}} solves it.
{quote}
The 
[newSSLEngine|https://github.com/djatnieks/cassandra/commit/1403bc0b40e54e15f41ba67711a15e0562064519#diff-c4146bf5532a39b21c5e06d95ae50514383d29e6f5289ba76a69625ab5cf2b14R281]
 calls the SSLEngine#newSSLEngine which does
{code:java}
if (this.cipherSuites != null) {
    engine.setEnabledCipherSuites(this.cipherSuites);
}{code}
>From the setEnabledCipherSuites javadoc:
{code:java}
Each cipher suite in the suites parameter must have been listed by 
getSupportedCipherSuites(), or the method will fail. Following a successful 
call to this method, only suites listed in the suites parameter are enabled for 
use.{code}

> BulkLoader withCipherSuites option is ignored
> ---------------------------------------------
>
>                 Key: CASSANDRA-18582
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-18582
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Tool/bulk load
>            Reporter: dan jatnieks
>            Assignee: dan jatnieks
>            Priority: Normal
>             Fix For: 4.0.x, 4.1.x, 5.x
>
>
> The {{withCipherSuites}} option of {{BulkLoader}} is being ignored. It seems 
> that since CASSANDRA-16362 the {{BulkLoader.buildSSLOptions}} method no 
> longer applies the cipher suite options provided by 
> {{clientEncryptionOptions}}.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to