[
https://issues.apache.org/jira/browse/CASSANDRA-18255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17745281#comment-17745281
]
Michael Semb Wever commented on CASSANDRA-18255:
------------------------------------------------
bq. If I do not add that check for 8, we will build also with JDK8 for trunk.
What do I miss?
Those scripts don't determine which JDKs to try and run with. That's defined
in the groovy first in your first commit in the PR.
The script just fails if it detects trunk (`java.supported` exists in build.xml
but does not contain "8"). But the script would fail anyway as soon as it
tries to invoke ant with JDK8.
> Drop JDK8 Support
> -----------------
>
> Key: CASSANDRA-18255
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18255
> Project: Cassandra
> Issue Type: Task
> Components: Build
> Reporter: Michael Semb Wever
> Assignee: Ekaterina Dimitrova
> Priority: High
> Fix For: 5.x
>
>
> * update Jenkins builds scripts (Cassandra-builds) for trunk to build and run
> tests only with JDK 11 and JDK 17 - both Jenkins-dev and post-commit
> * the JDK11+17 config files and script in cassandra/.circleci should replace
> the default J8+J11 test config files and script
> * Cassandra trunk build.xml and conf files should be updated - JDK8 removed
> everywhere
> * Any tickets blocked on this one and ready to commit should be committed
> * Revert this change in CCM -
> [https://github.com/riptano/ccm/commit/6e71061146f7ae67b84ccd2b1d90d7319b640e4c#diff-0999a90fd83b66b6840af0bbd8afd1ebd9648e135b0665692fa0f523325a1058L984]
> * Docs will be updated later in CASSANDRA-18233
> NOTE: Python Upgrade tests were already switched to 11 in this
> [change|https://github.com/apache/cassandra-dtest/commit/52053200e75d3e6718c03bfa68232dfb94f9a566#diff-31d0989c90471274d54ccce871e5ea977ba477d1b55ee13be6f399fd844c16cfR171],
> so I _think_ there is no other change pending in cassandra-dtest repo
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
